Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-16135: fix deletion bug when hostedzone is already deleted #2811

Merged
merged 1 commit into from Jul 13, 2023

Conversation

mjlshen
Copy link
Contributor

@mjlshen mjlshen commented Jul 13, 2023

What this PR does / why we need it:

This commit fixes a case where the deletion of an awsendpointservice can hang when the control plane operator is unable to perform route53:ListResourceRecordSets due to the Route53 Hosted Zone not existing anymore. In this case, we should just exit early as the record no longer exists.

Which issue(s) this PR fixes:
Fixes OCPBUGS-16135

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci openshift-ci bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release and removed do-not-merge/needs-area labels Jul 13, 2023
This commit fixes a case where the deletion of an awsendpointservice can
hang when the control plane operator is unable to perform
route53:ListResourceRecordSets due to the Route53 Hosted Zone not
existing anymore. In this case, we should just exit early as the record
no longer exists.

Signed-off-by: Michael Shen <mshen@redhat.com>
@mjlshen mjlshen changed the title OCPBUGS-16135 fix deletion bug when hostedzone is already deleted OCPBUGS-16135: fix deletion bug when hostedzone is already deleted Jul 13, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 13, 2023
@openshift-ci-robot
Copy link

@mjlshen: This pull request references Jira Issue OCPBUGS-16135, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What this PR does / why we need it:

This commit fixes a case where the deletion of an awsendpointservice can hang when the control plane operator is unable to perform route53:ListResourceRecordSets due to the Route53 Hosted Zone not existing anymore. In this case, we should just exit early as the record no longer exists.

Which issue(s) this PR fixes:
Fixes OCPBUGS-16135

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjlshen
Copy link
Contributor Author

mjlshen commented Jul 13, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 13, 2023
@openshift-ci-robot
Copy link

@mjlshen: This pull request references Jira Issue OCPBUGS-16135, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2023

@mjlshen: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@enxebre
Copy link
Member

enxebre commented Jul 13, 2023

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, mjlshen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2023
Copy link
Contributor

@jparrill jparrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2023
@openshift-merge-robot openshift-merge-robot merged commit 7b70890 into openshift:main Jul 13, 2023
12 checks passed
@openshift-ci-robot
Copy link

@mjlshen: Jira Issue OCPBUGS-16135: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-16135 has been moved to the MODIFIED state.

In response to this:

What this PR does / why we need it:

This commit fixes a case where the deletion of an awsendpointservice can hang when the control plane operator is unable to perform route53:ListResourceRecordSets due to the Route53 Hosted Zone not existing anymore. In this case, we should just exit early as the record no longer exists.

Which issue(s) this PR fixes:
Fixes OCPBUGS-16135

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjlshen
Copy link
Contributor Author

mjlshen commented Jul 13, 2023

/cherry-pick release-4.13

@openshift-cherrypick-robot

@mjlshen: new pull request created: #2813

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjlshen mjlshen deleted the OCPBUGS-16135 branch July 13, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants