New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-16135: fix deletion bug when hostedzone is already deleted #2811
Conversation
This commit fixes a case where the deletion of an awsendpointservice can hang when the control plane operator is unable to perform route53:ListResourceRecordSets due to the Route53 Hosted Zone not existing anymore. In this case, we should just exit early as the record no longer exists. Signed-off-by: Michael Shen <mshen@redhat.com>
@mjlshen: This pull request references Jira Issue OCPBUGS-16135, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@mjlshen: This pull request references Jira Issue OCPBUGS-16135, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mjlshen: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Thanks! For the record https://docs.aws.amazon.com/Route53/latest/APIReference/API_ListResourceRecordSets.html |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre, mjlshen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@mjlshen: Jira Issue OCPBUGS-16135: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-16135 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.13 |
@mjlshen: new pull request created: #2813 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This commit fixes a case where the deletion of an awsendpointservice can hang when the control plane operator is unable to perform route53:ListResourceRecordSets due to the Route53 Hosted Zone not existing anymore. In this case, we should just exit early as the record no longer exists.
Which issue(s) this PR fixes:
Fixes OCPBUGS-16135
Checklist