Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-16221: Adds trust bundle to ignition-server when configured in HC #2819

Merged
merged 1 commit into from Sep 1, 2023

Conversation

mvazquezc
Copy link
Member

What this PR does / why we need it:

Ignition-server deployment doesn't configure the additionaltrustbundle configured by the user. This PR fixes that.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #OCPBUGS-16221

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Signed-off-by: Mario Vazquez <mavazque@redhat.com>
@openshift-ci openshift-ci bot requested review from csrwng and enxebre July 14, 2023 09:37
@openshift-ci openshift-ci bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release and removed do-not-merge/needs-area labels Jul 14, 2023
@mvazquezc mvazquezc changed the title Adds trust bundle to ignition-server when configured in HC OCPBUGS-16221: Adds trust bundle to ignition-server when configured in HC Jul 14, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 14, 2023
@openshift-ci-robot
Copy link

@mvazquezc: This pull request references Jira Issue OCPBUGS-16221, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What this PR does / why we need it:

Ignition-server deployment doesn't configure the additionaltrustbundle configured by the user. This PR fixes that.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #OCPBUGS-16221

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jparrill
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2023
@jparrill
Copy link
Contributor

/retest

@enxebre
Copy link
Member

enxebre commented Aug 31, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, mvazquezc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2023
@jparrill
Copy link
Contributor

To add more context, the issue happens in the IgnitionServer when it tries to generate the payload. It tries to extract some metadata image and gives this error:

{"level":"error","ts":"2023-08-31T09:04:58Z","msg":"Reconciler error","controller":"secret","controllerGroup":"","controllerKind":"Secret","Secret":{"name":"token-hosted-7b60313e","namespace":"clusters-hosted"},"namespace":"clusters-hosted","name":"token-hosted-7b60313e","reconcileID":"64779bf2-6936-420f-aee3-44bd2d0813d4","error":"error getting ignition payload: failed to get component images: failed to look up release image metadata: failed to extract release metadata: failed to get repo setup: failed to create repository client for https://registry.hypershiftbm.lab:5000/: Get \"https://registry.hypershiftbm.lab:5000/v2/\": x509: certificate signed by unknown authority","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/hypershift/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:326\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/hypershift/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:273\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/hypershift/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:234"}

@jparrill
Copy link
Contributor

Patch validated in IPv6/Disconnected environment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8b4b529 and 2 for PR HEAD 5fb8b47 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 7c41b8a and 1 for PR HEAD 5fb8b47 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c877104 and 0 for PR HEAD 5fb8b47 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2023

@mvazquezc: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit b9d4e6f into openshift:main Sep 1, 2023
14 checks passed
@openshift-ci-robot
Copy link

@mvazquezc: Jira Issue OCPBUGS-16221: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-16221 has been moved to the MODIFIED state.

In response to this:

What this PR does / why we need it:

Ignition-server deployment doesn't configure the additionaltrustbundle configured by the user. This PR fixes that.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #OCPBUGS-16221

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants