Revert "HOSTEDCP-710: Make ImageContentSource immutable"

[relyt0925]

Reverts #2815

This is necessary for the ability to convert from public endpoints (public registries) to private endpoints (private registries) in IBM Cloud

[openshift-ci-robot]

@relyt0925: This pull request references HOSTEDCP-710 which is a valid jira issue.

In response to this:

Reverts #2815

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[relyt0925]

/assign @bryan-cox

[bryan-cox]

/lgtm

[openshift-ci-robot]

@relyt0925: This pull request references HOSTEDCP-710 which is a valid jira issue.

In response to this:

Reverts #2815

This is necessary for the ability to convert from public endpoints (public registries) to private endpoints (private registries) in IBM Cloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[relyt0925]

/retest

[enxebre]

@bryan-cox please let's put together a list of all the fields that need be immutable and would require a rolling update on Nodes but we don't trigger it yet. Then let's documente that limitation. Then let's double check with IBM for each of them and let's make the ones which are not disrupting for them we enforce immutability until we plan to support triggering rolling upgrade for each

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, enxebre, relyt0925

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [enxebre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bryan-cox]

/test e2e-aws

[bryan-cox]

/test e2e-aws

[openshift-ci]

@relyt0925: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-ibmcloud-roks	433249e	link	false	/test e2e-ibmcloud-roks
ci/prow/e2e-ibmcloud-iks	433249e	link	false	/test e2e-ibmcloud-iks

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.