Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOSTEDCP-1114: [backport-4.13] validate release payload images #2856

Closed
wants to merge 3 commits into from

Conversation

bryan-cox
Copy link
Member

What this PR does / why we need it:
Backports #2368 and #2441 to release-4.13.

Which issue(s) this PR fixes:
Fixes HOSTEDCP-1114

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes unit tests.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 26, 2023

@bryan-cox: This pull request references HOSTEDCP-1114 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
Backports #2368 and #2441 to release-4.13.

Which issue(s) this PR fixes:
Fixes HOSTEDCP-1114

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 26, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 26, 2023
@openshift-ci openshift-ci bot added do-not-merge/needs-area area/ci-tooling Indicates the PR includes changes for CI or tooling labels Jul 26, 2023
@bryan-cox bryan-cox changed the base branch from main to release-4.13 July 26, 2023 18:55
@openshift-ci openshift-ci bot added the area/cli Indicates the PR includes changes for CLI label Jul 26, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 26, 2023

@bryan-cox: This pull request references HOSTEDCP-1114 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
Backports #2368 and #2441 to release-4.13.

Which issue(s) this PR fixes:
Fixes HOSTEDCP-1114

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/documentation Indicates the PR includes changes for documentation and removed do-not-merge/needs-area labels Jul 26, 2023
@netlify
Copy link

netlify bot commented Jul 26, 2023

Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit 9060e16
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/64c16bf30a1a5d00084e5958
😎 Deploy Preview https://deploy-preview-2856--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@openshift-ci openshift-ci bot added area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release area/testing Indicates the PR includes changes for e2e testing labels Jul 26, 2023
@bryan-cox
Copy link
Member Author

/test e2e-aws

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 26, 2023
@muraee
Copy link
Contributor

muraee commented Jul 27, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2023
@bryan-cox
Copy link
Member Author

/test e2e-aws

1 similar comment
@bryan-cox
Copy link
Member Author

/test e2e-aws

@bryan-cox bryan-cox marked this pull request as ready for review July 31, 2023 12:06
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 31, 2023
@bryan-cox
Copy link
Member Author

/test verify

Validates and report missing images in the release payload in ValidReleaseInfo condition

Signed-off-by: Bryan Cox <brcox@redhat.com>
Signed-off-by: Bryan Cox <brcox@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 31, 2023

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 31, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bryan-cox
Once this PR has been reviewed and has the lgtm label, please assign enxebre for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bryan-cox
Copy link
Member Author

/test e2e-aws

1 similar comment
@bryan-cox
Copy link
Member Author

/test e2e-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 31, 2023

@bryan-cox: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws 9480b2f link true /test e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bryan-cox
Copy link
Member Author

Talked with Toni this morning and we will not need this PR for 4.13. Closing PR.

@bryan-cox bryan-cox closed this Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/documentation Indicates the PR includes changes for documentation area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release area/testing Indicates the PR includes changes for e2e testing jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants