Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOSTEDCP-1022: Set Arch to amd64 #2897

Merged
merged 1 commit into from Aug 11, 2023

Conversation

bryan-cox
Copy link
Member

What this PR does / why we need it:
Sets Arch to amd64 so the InstanceType is chosen through the HCP CLI. This is consistent with how the hypershift CLI sets Arch as well.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes HOSTEDCP-1022

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Sets Arch to amd64 so the InstanceType is chosen through the HCP CLI.
This is consistent with how the hypershift CLI sets Arch as well.

Signed-off-by: Bryan Cox <brcox@redhat.com>
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 10, 2023

@bryan-cox: This pull request references HOSTEDCP-1022 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
Sets Arch to amd64 so the InstanceType is chosen through the HCP CLI. This is consistent with how the hypershift CLI sets Arch as well.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes HOSTEDCP-1022

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 10, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 10, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@csrwng
Copy link
Contributor

csrwng commented Aug 10, 2023

/approve

@bryan-cox bryan-cox marked this pull request as ready for review August 10, 2023 17:26
@bryan-cox
Copy link
Member Author

/area cli

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, csrwng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cli Indicates the PR includes changes for CLI and removed do-not-merge/needs-area labels Aug 10, 2023
@LiangquanLi930
Copy link
Member

/test e2e-kubevirt-aws-ovn

@LiangquanLi930
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d806b54 and 2 for PR HEAD 20a6e4f in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6ba4c1f and 1 for PR HEAD 20a6e4f in total

@csrwng
Copy link
Contributor

csrwng commented Aug 11, 2023

/override ci/prow/e2e-kubevirt-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2023

@csrwng: Overrode contexts on behalf of csrwng: ci/prow/e2e-kubevirt-aws-ovn

In response to this:

/override ci/prow/e2e-kubevirt-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit e62dc95 into openshift:main Aug 11, 2023
12 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2023

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bryan-cox bryan-cox deleted the HOSTEDCP-1022 branch August 11, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cli Indicates the PR includes changes for CLI jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants