Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOSTEDCP-1146: cpo: use CPO spec container image if it is a sha256 reference #2899

Merged
merged 1 commit into from Aug 11, 2023

Conversation

sjenning
Copy link
Contributor

In preparation for an e2e to verify proper ControlPlaneRelease function, I noticed that containers that use the self-referencing image lookup by the CPO were using an image ref different from that of the CPO itself.

This occurs when the ControlPlaneRelease image is set to a release image that shares an identical CPO image with the Release image. In that case, the imageID still contains the Release reference to the image, since the sha256 is the same; only the registry path is different.

In order to verify that all HCP containers are using the ControlPlaneRelease image, we need all containers to reflect the expected registry path.

@sjenning
Copy link
Contributor Author

cc @csrwng

@csrwng
Copy link
Contributor

csrwng commented Aug 10, 2023

/lgtm

@sjenning sjenning marked this pull request as ready for review August 10, 2023 17:54
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 10, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 10, 2023

@sjenning: This pull request references HOSTEDCP-1146 which is a valid jira issue.

In response to this:

In preparation for an e2e to verify proper ControlPlaneRelease function, I noticed that containers that use the self-referencing image lookup by the CPO were using an image ref different from that of the CPO itself.

This occurs when the ControlPlaneRelease image is set to a release image that shares an identical CPO image with the Release image. In that case, the imageID still contains the Release reference to the image, since the sha256 is the same; only the registry path is different.

In order to verify that all HCP containers are using the ControlPlaneRelease image, we need all containers to reflect the expected registry path.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 10, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-area area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release labels Aug 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 10, 2023
@openshift-ci openshift-ci bot requested review from csrwng and hasueki August 10, 2023 18:00
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/needs-area labels Aug 10, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d806b54 and 2 for PR HEAD 8490b98 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6ba4c1f and 1 for PR HEAD 8490b98 in total

@openshift-merge-robot openshift-merge-robot merged commit c5ee9a4 into openshift:main Aug 11, 2023
11 of 12 checks passed
@sjenning
Copy link
Contributor Author

sjenning commented Dec 7, 2023

/cherry-pick release-4.13

@openshift-cherrypick-robot

@sjenning: new pull request created: #3296

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants