New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HOSTEDCP-1146: cpo: use CPO spec container image if it is a sha256 reference #2899
HOSTEDCP-1146: cpo: use CPO spec container image if it is a sha256 reference #2899
Conversation
cc @csrwng |
/lgtm |
@sjenning: This pull request references HOSTEDCP-1146 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-4.13 |
@sjenning: new pull request created: #3296 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In preparation for an e2e to verify proper ControlPlaneRelease function, I noticed that containers that use the self-referencing image lookup by the CPO were using an image ref different from that of the CPO itself.
This occurs when the
ControlPlaneRelease
image is set to a release image that shares an identical CPO image with theRelease
image. In that case, theimageID
still contains theRelease
reference to the image, since the sha256 is the same; only the registry path is different.In order to verify that all HCP containers are using the
ControlPlaneRelease
image, we need all containers to reflect the expected registry path.