Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOSTEDCP-1156: Add defaulting webhook to installation and notes #2922

Merged
merged 1 commit into from Sep 1, 2023

Conversation

bryan-cox
Copy link
Member

What this PR does / why we need it:
Adds the enable-defaulting-webhook flag to the hypershift install and a note about the flag only being available for OCP versions greater than or equal to 4.14.

Adds note to create cluster command that either the release-image or release-stream flag is needed when the enable-defaulting-webhook is not available.

Which issue(s) this PR fixes:
Fixes HOSTEDCP-1156

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Adds the enable-defaulting-webhook flag to the hypershift install and a
note about the flag only being available for OCP versions greater than
or equal to 4.14. Adds note to create cluster command that either the
release-image or release-stream flag is needed when the
enable-defaulting-webhook is not available.

Signed-off-by: Bryan Cox <brcox@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 21, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 21, 2023

@bryan-cox: This pull request references HOSTEDCP-1156 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
Adds the enable-defaulting-webhook flag to the hypershift install and a note about the flag only being available for OCP versions greater than or equal to 4.14.

Adds note to create cluster command that either the release-image or release-stream flag is needed when the enable-defaulting-webhook is not available.

Which issue(s) this PR fixes:
Fixes HOSTEDCP-1156

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 21, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added do-not-merge/needs-area area/documentation Indicates the PR includes changes for documentation and removed do-not-merge/needs-area labels Aug 21, 2023
@netlify
Copy link

netlify bot commented Aug 21, 2023

Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit 43149e8
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/64e35220446f0900085c9e65
😎 Deploy Preview https://deploy-preview-2922--hypershift-docs.netlify.app/getting-started
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bryan-cox
Copy link
Member Author

Adds documentation requested in #2892 (comment)

@muraee
Copy link
Contributor

muraee commented Aug 21, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2023
Copy link
Contributor

@jparrill jparrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@enxebre
Copy link
Member

enxebre commented Sep 1, 2023

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2023
@bryan-cox bryan-cox marked this pull request as ready for review September 1, 2023 11:57
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 1, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2023

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 1cc66b0 into openshift:main Sep 1, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Indicates the PR includes changes for documentation jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants