New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HOSTEDCP-1156: Add defaulting webhook to installation and notes #2922
Conversation
Adds the enable-defaulting-webhook flag to the hypershift install and a note about the flag only being available for OCP versions greater than or equal to 4.14. Adds note to create cluster command that either the release-image or release-stream flag is needed when the enable-defaulting-webhook is not available. Signed-off-by: Bryan Cox <brcox@redhat.com>
@bryan-cox: This pull request references HOSTEDCP-1156 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Skipping CI for Draft Pull Request. |
✅ Deploy Preview for hypershift-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Adds documentation requested in #2892 (comment) |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryan-cox, enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@bryan-cox: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What this PR does / why we need it:
Adds the enable-defaulting-webhook flag to the hypershift install and a note about the flag only being available for OCP versions greater than or equal to 4.14.
Adds note to create cluster command that either the release-image or release-stream flag is needed when the enable-defaulting-webhook is not available.
Which issue(s) this PR fixes:
Fixes HOSTEDCP-1156
Checklist