ACM-6435: add pausedUntil create cluster option in CLI #2965

rokej · 2023-08-30T18:41:27Z

What this PR does / why we need it:

This PR is to add pausedUntil create cluster option in hcp CLI to support MCE's cluster create/update Ansible automation template. https://issues.redhat.com/browse/ACM-1368

MCE is integrated with Red Hat Ansible Automation Platform so that you can create prehook and posthook Ansible job instances that occur before or after creating or upgrading hive clusters. MCE should provide users same experience with hosted clusters. This requires an ability to pause cluster provisioning so that prehook job can be executed before cluster creation. MCE's cluster curator controller orchestrates this and clears the spec.pausedUntil from the HostedCluster and NodePools when the conditions are met.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

Subject and description added to both, commit and PR.
Relevant issues have been referenced.
This change includes docs.
This change includes unit tests.

Signed-off-by: Roke Jung <roke@redhat.com>

bryan-cox · 2023-08-30T19:16:15Z

/retitle: ACM-6435: add pausedUntil create cluster option in CLI

product-cli/cmd/cluster/cluster.go

openshift-ci-robot · 2023-08-30T20:10:50Z

@rokej: This pull request references ACM-6435 which is a valid jira issue.

In response to this:

What this PR does / why we need it:

This PR is to add pausedUntil create cluster option in hcp CLI to support MCE's cluster create/update Ansible automation template. https://issues.redhat.com/browse/ACM-1368

MCE's cluster curator controller will clear the spec.pausedUntil from the HostedCluster and NodePools when the conditions are met.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bryan-cox · 2023-08-31T10:56:14Z

/retitle ACM-6435: add pausedUntil create cluster option in CLI

rokej · 2023-08-31T14:37:52Z

/retest

rokej · 2023-08-31T18:26:29Z

/retest

cmd/cluster/core/create.go

hypershift-operator/controllers/hostedcluster/hostedcluster_controller.go

Co-authored-by: Bryan Cox <brcox@redhat.com>

netlify · 2023-09-01T14:03:10Z

✅ Deploy Preview for hypershift-docs ready!

Name	Link
🔨 Latest commit	`5143770`
🔍 Latest deploy log	https://app.netlify.com/sites/hypershift-docs/deploys/64f1eeee666b590008b7bd84
😎 Deploy Preview	https://deploy-preview-2965--hypershift-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Roke Jung <roke@redhat.com>

bryan-cox

/lgtm

hypershift-operator/controllers/hostedcluster/hostedcluster_controller.go

enxebre · 2023-09-05T13:59:05Z

Can you elaborate on the value of creating a paused cluster? how are you planning to cleanup the field?
If we move forward with this can we please add the same flag to the dev cli so product one is a subset of the dev one.

openshift-ci-robot · 2023-09-05T15:13:25Z

@rokej: This pull request references ACM-6435 which is a valid jira issue.

In response to this:

What this PR does / why we need it:

This PR is to add pausedUntil create cluster option in hcp CLI to support MCE's cluster create/update Ansible automation template. https://issues.redhat.com/browse/ACM-1368

MCE is integrated with Red Hat Ansible Automation Platform so that you can create prehook and posthook Ansible job instances that occur before or after creating or upgrading hive clusters. MCE should provide users same experience with hosted clusters. This requires an ability to pause cluster provisioning so that prehook job can be executed before cluster creation. MCE's cluster curator controller orchestrates this and clears the spec.pausedUntil from the HostedCluster and NodePools when the conditions are met.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rokej · 2023-09-05T15:14:28Z

@enxebre Please see the updated PR description for the value of creating a paused cluster. The dev CLI was updated as well.

Signed-off-by: Roke Jung <roke@redhat.com>

enxebre · 2023-09-05T15:46:40Z

/approve

bryan-cox

/lgtm

Signed-off-by: Roke Jung <roke@redhat.com>

bryan-cox

/lgtm

openshift-ci · 2023-09-05T17:39:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, enxebre, rokej

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [enxebre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2023-09-05T18:58:43Z

/retest-required

Remaining retests: 0 against base HEAD 068f642 and 2 for PR HEAD 21c0c17 in total

openshift-ci-robot · 2023-09-05T23:18:58Z

/retest-required

Remaining retests: 0 against base HEAD ca52dd7 and 1 for PR HEAD 21c0c17 in total

openshift-ci-robot · 2023-09-06T05:58:42Z

/retest-required

Remaining retests: 0 against base HEAD 9fbb713 and 0 for PR HEAD 21c0c17 in total

openshift-ci-robot · 2023-09-06T14:11:02Z

/hold

Revision 21c0c17 was retested 3 times: holding

rokej · 2023-09-06T15:23:04Z

/test e2e-aws

openshift-ci · 2023-09-06T16:45:54Z

@rokej: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-ibmcloud-iks	`21c0c17`	link	false	`/test e2e-ibmcloud-iks`
ci/prow/e2e-ibmcloud-roks	`21c0c17`	link	false	`/test e2e-ibmcloud-roks`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

rokej · 2023-09-06T17:09:43Z

/test e2e-aws

rokej · 2023-09-06T19:33:07Z

/unhold

add pausedUntil create cluster option in CLI

5ec7888

Signed-off-by: Roke Jung <roke@redhat.com>

bryan-cox reviewed Aug 30, 2023

View reviewed changes

product-cli/cmd/cluster/cluster.go Outdated Show resolved Hide resolved

openshift-ci bot added the do-not-merge/needs-area label Aug 30, 2023

openshift-ci bot requested review from csrwng and enxebre August 30, 2023 19:58

openshift-ci bot added area/cli Indicates the PR includes changes for CLI area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release and removed do-not-merge/needs-area labels Aug 30, 2023

openshift-ci bot changed the title ~~add pausedUntil create cluster option in CLI~~ : ACM-6435: add pausedUntil create cluster option in CLI Aug 30, 2023

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 30, 2023

openshift-ci bot changed the title ~~: ACM-6435: add pausedUntil create cluster option in CLI~~ ACM-6435: add pausedUntil create cluster option in CLI Aug 31, 2023

bryan-cox reviewed Sep 1, 2023

View reviewed changes

cmd/cluster/core/create.go Outdated Show resolved Hide resolved

cmd/cluster/core/create.go Outdated Show resolved Hide resolved

hypershift-operator/controllers/hostedcluster/hostedcluster_controller.go Outdated Show resolved Hide resolved

Update cmd/cluster/core/create.go

5143770

Co-authored-by: Bryan Cox <brcox@redhat.com>

rokej added 2 commits September 1, 2023 10:40

simplify code

9268e4b

Signed-off-by: Roke Jung <roke@redhat.com>

simplfy more code

6888432

Signed-off-by: Roke Jung <roke@redhat.com>

bryan-cox approved these changes Sep 1, 2023

View reviewed changes

openshift-ci bot assigned bryan-cox Sep 1, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2023

enxebre reviewed Sep 5, 2023

View reviewed changes

hypershift-operator/controllers/hostedcluster/hostedcluster_controller.go Outdated Show resolved Hide resolved

add pausedUntil create cluster option to dev hypershift CLI

d6f38dd

Signed-off-by: Roke Jung <roke@redhat.com>

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2023

bryan-cox approved these changes Sep 5, 2023

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2023

return earlier if there is no HCP to pause

62664a4

Signed-off-by: Roke Jung <roke@redhat.com>

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2023

rokej requested review from bryan-cox and enxebre September 5, 2023 17:28

return earlier if there is no HCP to pause

21c0c17

Signed-off-by: Roke Jung <roke@redhat.com>

bryan-cox approved these changes Sep 5, 2023

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2023

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2023

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2023

openshift-merge-robot merged commit 27d1f37 into openshift:main Sep 6, 2023
13 of 15 checks passed

rokej deleted the cli-pausedUntil branch September 7, 2023 00:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ACM-6435: add pausedUntil create cluster option in CLI #2965

ACM-6435: add pausedUntil create cluster option in CLI #2965

rokej commented Aug 30, 2023 •

edited

bryan-cox commented Aug 30, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Aug 30, 2023 •

edited by openshift-ci bot

bryan-cox commented Aug 31, 2023 •

edited by openshift-ci bot

rokej commented Aug 31, 2023

rokej commented Aug 31, 2023

netlify bot commented Sep 1, 2023

bryan-cox left a comment

enxebre commented Sep 5, 2023

openshift-ci-robot commented Sep 5, 2023 •

edited by openshift-ci bot

rokej commented Sep 5, 2023 •

edited

enxebre commented Sep 5, 2023

bryan-cox left a comment

bryan-cox left a comment

openshift-ci bot commented Sep 5, 2023

openshift-ci-robot commented Sep 5, 2023

openshift-ci-robot commented Sep 5, 2023

openshift-ci-robot commented Sep 6, 2023

openshift-ci-robot commented Sep 6, 2023

rokej commented Sep 6, 2023

openshift-ci bot commented Sep 6, 2023 •

edited

rokej commented Sep 6, 2023

rokej commented Sep 6, 2023

ACM-6435: add pausedUntil create cluster option in CLI #2965

ACM-6435: add pausedUntil create cluster option in CLI #2965

Conversation

rokej commented Aug 30, 2023 • edited

bryan-cox commented Aug 30, 2023 • edited by openshift-ci bot

openshift-ci-robot commented Aug 30, 2023 • edited by openshift-ci bot

bryan-cox commented Aug 31, 2023 • edited by openshift-ci bot

rokej commented Aug 31, 2023

rokej commented Aug 31, 2023

netlify bot commented Sep 1, 2023

✅ Deploy Preview for hypershift-docs ready!

bryan-cox left a comment

Choose a reason for hiding this comment

enxebre commented Sep 5, 2023

openshift-ci-robot commented Sep 5, 2023 • edited by openshift-ci bot

rokej commented Sep 5, 2023 • edited

enxebre commented Sep 5, 2023

bryan-cox left a comment

Choose a reason for hiding this comment

bryan-cox left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Sep 5, 2023

openshift-ci-robot commented Sep 5, 2023

openshift-ci-robot commented Sep 5, 2023

openshift-ci-robot commented Sep 6, 2023

openshift-ci-robot commented Sep 6, 2023

rokej commented Sep 6, 2023

openshift-ci bot commented Sep 6, 2023 • edited

rokej commented Sep 6, 2023

rokej commented Sep 6, 2023

rokej commented Aug 30, 2023 •

edited

bryan-cox commented Aug 30, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Aug 30, 2023 •

edited by openshift-ci bot

bryan-cox commented Aug 31, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Sep 5, 2023 •

edited by openshift-ci bot

rokej commented Sep 5, 2023 •

edited

openshift-ci bot commented Sep 6, 2023 •

edited