OCPBUGS-18438: Properly format IPv6 address when proxying it through Konnectivity

[csrwng]

What this PR does / why we need it:
When sending a numeric IPv6 address to the proxy in a CONNECT request, the address needs to be surrounded by brackets, otherwise the proxy sends back a Bad Request (400) result.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [csrwng]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jparrill]

For more context in this issue:

After a HC deployment in a IPv6/Disconnected environment we can see that the Ingress ClusterOperator does not work properly:

clusteroperator.config.openshift.io/ingress                                    4.14.0-0.nightly-2023-08-29-102237   True        False         True	 43m     The "default" ingress controller reports Degraded=True: DegradedConditions: One or more other status conditions indicate a degraded state: CanaryChecksSucceeding=False (CanaryChecksRepetitive Failures: Canary route checks for the default ingress controller are failing)

Also we can see the canary route accesible from the ingressOperator pod using curl command but the golang code doesn't.

2023-08-31T16:23:07.264Z	ERROR	operator.canary_controller	wait/backoff.go:226	error performing canary route check	{"error": "error sending canary HTTP request to \"canary-openshift-ingress-canary.apps.hosted.hypershiftbm.lab\": Get \"https://canary-openshift-ingress-canary.apps.hosted.hypershiftbm.lab/\": socks connect tcp 127.0.0.1:8090->canary-openshift-ingress-canary.apps.hosted.hypershiftbm.lab:443: unknown error host unreachable"}

[jparrill]

/lgtm

[jparrill]

/retitle OCPBUGS-18438: Properly format IPv6 address when proxying it through Konnectivity

[openshift-ci-robot]

@csrwng: This pull request references Jira Issue OCPBUGS-18438, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @LiangquanLi930

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What this PR does / why we need it:
When sending a numeric IPv6 address to the proxy in a CONNECT request, the address needs to be surrounded by brackets, otherwise the proxy sends back a Bad Request (400) result.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 1cc66b0 and 2 for PR HEAD 79618ba in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 9e9bb50 and 1 for PR HEAD 79618ba in total

[jparrill]

/test e2e-kubevirt-aws-ovn

[openshift-ci]

@csrwng: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@csrwng: Jira Issue OCPBUGS-18438: All pull requests linked via external trackers have merged:

• openshift/hypershift#2969

Jira Issue OCPBUGS-18438 has been moved to the MODIFIED state.

In response to this:

What this PR does / why we need it:
When sending a numeric IPv6 address to the proxy in a CONNECT request, the address needs to be surrounded by brackets, otherwise the proxy sends back a Bad Request (400) result.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-merge-robot]

Fix included in accepted release 4.14.0-0.nightly-2023-09-11-201102

[openshift-merge-robot]

Fix included in accepted release 4.14.0-0.nightly-2023-09-12-024050

[openshift-merge-robot]

Fix included in accepted release 4.14.0-0.nightly-2023-09-15-101929