Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOSTEDCP-1185: Add flag to create a single NAT gateway #2984

Merged
merged 1 commit into from Sep 8, 2023

Conversation

csrwng
Copy link
Contributor

@csrwng csrwng commented Sep 5, 2023

What this PR does / why we need it:
When creating multi-zone hosted clusters, the --single-nat-gateway flag allows creating a single nat gateway instead of 3 and configures all cluster traffic to flow through that gateway. This is meant to be used in development and testing so that we can avoid spending on a nat gateway for every zone of a hosted cluster.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #HOSTEDCP-1185

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

When creating multi-zone hosted clusters, the --single-nat-gateway flag
allows creating a single nat gateway instead of 3 and configures all
cluster traffic to flow through that gateway. This is meant to be used
in development and testing so that we can avoid spending on a nat
gateway for every zone of a hosted cluster.
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 5, 2023

@csrwng: This pull request references HOSTEDCP-1185 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
When creating multi-zone hosted clusters, the --single-nat-gateway flag allows creating a single nat gateway instead of 3 and configures all cluster traffic to flow through that gateway. This is meant to be used in development and testing so that we can avoid spending on a nat gateway for every zone of a hosted cluster.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #HOSTEDCP-1185

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 5, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 5, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added do-not-merge/needs-area area/cli Indicates the PR includes changes for CLI labels Sep 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Sep 5, 2023
@enxebre
Copy link
Member

enxebre commented Sep 6, 2023

do we want to also set this in the HCs created by CI and start analize impact on AWS cost?

@csrwng
Copy link
Contributor Author

csrwng commented Sep 6, 2023

do we want to also set this in the HCs created by CI and start analize impact on AWS cost?

Yes, that's the intent

@enxebre
Copy link
Member

enxebre commented Sep 7, 2023

do we want to also set this in the HCs created by CI and start analize impact on AWS cost?
Yes, that's the intent

I mean it seems we are not exercising the new flag change in the cli for the tests in this PR?

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2023
@csrwng
Copy link
Contributor Author

csrwng commented Sep 7, 2023

I mean it seems we are not exercising the new flag change in the cli for the tests in this PR?

Sorry, I see what you mean. I was planning to do that in a separate PR.

@csrwng csrwng marked this pull request as ready for review September 7, 2023 17:00
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 8, 2023

@csrwng: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit d5d15ac into openshift:main Sep 8, 2023
13 checks passed
@csrwng csrwng deleted the single_nat_gateway branch November 15, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cli Indicates the PR includes changes for CLI jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants