New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-18568: Use MCO and CCO image references when looking up mappings #2985
OCPBUGS-18568: Use MCO and CCO image references when looking up mappings #2985
Conversation
Skipping CI for Draft Pull Request. |
@csrwng: This pull request references Jira Issue OCPBUGS-18568, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csrwng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
14f228b
to
5d76d0a
Compare
Currently, we unconditionally use an image mapping from the management cluster if a mapping exists for ocp-release-dev or ocp/release. When the individual images do not use those registries, the wrong mapping is used. This commit uses the individual images from the payload to look for any image mappings that may exist on the management cluster.
5d76d0a
to
18ff7de
Compare
The brackets surrounding an IPv6 address were not getting added at the right time. They need to be added before sending an address to be resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm |
/test e2e-aws |
@csrwng: Jira Issue OCPBUGS-18568: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-18568 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fix included in accepted release 4.14.0-0.nightly-2023-09-11-201102 |
Fix included in accepted release 4.14.0-0.nightly-2023-09-12-024050 |
Fix included in accepted release 4.14.0-0.nightly-2023-09-15-101929 |
What this PR does / why we need it:
Currently, we unconditionally use an image mapping from the management cluster if a mapping exists for ocp-release-dev or ocp/release. When the individual images do not use those registries, the wrong mapping is used.
This commit uses the individual images from the payload to look for any image mappings that may exist on the management cluster.
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)
format, where issue_number might be a GitHub issue, or a Jira story:Fixes # OCPBUGS-18568
Checklist