Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: fixed gomega created from parent test context #2987

Merged
merged 1 commit into from Sep 11, 2023

Conversation

muraee
Copy link
Contributor

@muraee muraee commented Sep 6, 2023

What this PR does / why we need it:
currently the Main tests use a gomega var g created from the parent test contest t instead from the subtest.

On failure, this causes the error logs to be scrambled and the following error to show:

testing.go:1343: test executed panic(nil) or runtime.Goexit: subtest may have called FailNow on a parent test

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 6, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added do-not-merge/needs-area area/testing Indicates the PR includes changes for e2e testing and removed do-not-merge/needs-area labels Sep 6, 2023
@muraee
Copy link
Contributor Author

muraee commented Sep 6, 2023

/test e2e-aws

2 similar comments
@muraee
Copy link
Contributor Author

muraee commented Sep 6, 2023

/test e2e-aws

@muraee
Copy link
Contributor Author

muraee commented Sep 7, 2023

/test e2e-aws

@muraee muraee marked this pull request as ready for review September 7, 2023 14:58
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 7, 2023
@enxebre
Copy link
Member

enxebre commented Sep 8, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, muraee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2023
@netlify
Copy link

netlify bot commented Sep 8, 2023

Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit 922ef19
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/64fb3850b9dbb6000894b894
😎 Deploy Preview https://deploy-preview-2987--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@csrwng
Copy link
Contributor

csrwng commented Sep 8, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d5d15ac and 2 for PR HEAD 922ef19 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 74718b2 and 1 for PR HEAD 922ef19 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 14745d9 and 0 for PR HEAD 922ef19 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2023

@muraee: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 562b4e9 into openshift:main Sep 11, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Indicates the PR includes changes for e2e testing lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants