New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add _id label to all hypershift operator metrics #2991
feat: add _id label to all hypershift operator metrics #2991
Conversation
✅ Deploy Preview for hypershift-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre, typeid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/lgtm |
@typeid: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What this PR does / why we need it:
This PR adds the
_id
label to all the hypershift operator metrics that didn't have it yet.For ROSA, this significantly facilitates promql queries on metrics coming from the hypershift operator and hosted clusters, as the hosted cluster metrics also contain the same
_id
label.Currently, to combine metrics from HC and the hypershift operator in a query, we need to aggregate another metric containing both
_id
andexported_namespace
. With this change, we can directly aggregate through_id
.Which issue(s) this PR fixes
Fixes #HOSTEDCP-1183 (note the ticket isn't groomed yet)
Checklist