Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HYPBLD-99: enable CGO_ENABLED for building FIPS compliant images #2997

Merged
merged 1 commit into from Sep 11, 2023
Merged

Conversation

rokej
Copy link
Contributor

@rokej rokej commented Sep 7, 2023

What this PR does / why we need it:

The current hypershift operator cannot be run in FIPS enabled cluster because the binary is not FIPS compliant. In order to build FIPS compliant images, CGO_ENABLED needs to be set to 1.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

https://issues.redhat.com/browse/HYPBLD-99

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Signed-off-by: Roke Jung <roke@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 7, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 7, 2023

@rokej: This pull request references HYPBLD-99 which is a valid jira issue.

In response to this:

What this PR does / why we need it:

The current hypershift operator cannot be run in FIPS enabled cluster because the binary is not FIPS compliant. In order to build FIPS compliant images, CGO_ENABLED needs to be set to 1.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

https://issues.redhat.com/browse/HYPBLD-99

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csrwng
Copy link
Contributor

csrwng commented Sep 7, 2023

/approve

@csrwng
Copy link
Contributor

csrwng commented Sep 7, 2023

/area hypershift-operator
/area control-plane-operator

@openshift-ci openshift-ci bot added area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Sep 7, 2023
Copy link
Member

@bryan-cox bryan-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, csrwng, rokej

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d5d15ac and 2 for PR HEAD 783083a in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 74718b2 and 1 for PR HEAD 783083a in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 14745d9 and 0 for PR HEAD 783083a in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2023

@rokej: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 4f65601 into openshift:main Sep 11, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants