HOSTEDCP-1184: Document IPv6/IPv4/DualStack deployments for Hypershift in Baremetal

[jparrill]

Which issue(s) this PR fixes:
Fixes #HOSTEDCP-1184

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

[openshift-ci-robot]

@jparrill: This pull request references HOSTEDCP-1184 which is a valid jira issue.

In response to this:

Which issue(s) this PR fixes:
Fixes #HOSTEDCP-1184

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[netlify]

✅ Deploy Preview for hypershift-docs ready!

Name	Link
🔨 Latest commit	9f2a5b5
🔍 Latest deploy log	https://app.netlify.com/sites/hypershift-docs/deploys/651a9ad4f74249000804727b
😎 Deploy Preview	https://deploy-preview-3008--hypershift-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[bryan-cox]

I reviewed the first 10 files. I'll try to review the rest later.

[bryan-cox]

Made it 36 files in this time. It seems like quite a few of the /Dual/ markdown files are duplicated in the /IPv4/ section as well. Could they just reference the same markdown file if the content is the same?

[jparrill]

Made it 36 files in this time. It seems like quite a few of the /Dual/ markdown files are duplicated in the /IPv4/ section as well. Could they just reference the same markdown file if the content is the same?

Thanks for the review!, it's a huge PR, sorry about that.

Yes, when the file contains the same, I've placed the files in common/ folder but if it contains some differences, I maintain a copy of each one in their own folder.

[jparrill]

/test e2e-kubevirt-aws-ovn

[jparrill]

/retest

[enxebre]

Thanks for this effort, this is looking great! Can we have this section to be just another category of "how to"? along with AWS and other sections we have there.
Then a subcategory of this would be also "architecture", so all the self managed lab info is self contained there.

[jparrill]

The problem putting a new section in "how-to-guides" is, once you dropdown on this last section (it's very down bellow) the browser makes you go up because in fact it's a new page, so it's uncomfortable to keep going down every time you get into a new window. This is one of the reasons why I separated this section.

Regarding architecture section, I think it's better to keep it in Reference because it's not related with any Laboratory itself but the organically way to create the environment, it's like reference architectures.

[bryan-cox]

lgtm overall

[lahinson]

@jparrill If this step is mandatory for both connected and disconnected environments, does it override the info that we already have published for configuring DNS in the official docs?
You can see the source for the official docs related to DNS here: https://github.com/stolostron/rhacm-docs/blob/2.9_stage/clusters/hosted_control_planes/hosted_bare_metal_dns.adoc and https://github.com/stolostron/rhacm-docs/blob/2.9_stage/clusters/hosted_control_planes/hosted_bare_metal_dns.adoc.

[jparrill]

Good point, I don't think so (actually it's mostly the same), the only thing I would add is the same but in IPv6 and Dual stack (I made up the IP addresses).

which in IPv6 would be:

api.example.krnl.es.    IN A 2620:52:0:1306::5
api.example.krnl.es.    IN A 2620:52:0:1306::6
api.example.krnl.es.    IN A 2620:52:0:1306::7
api-int.example.krnl.es.    IN A 2620:52:0:1306::5
api-int.example.krnl.es.    IN A 2620:52:0:1306::6
api-int.example.krnl.es.    IN A 2620:52:0:1306::7
`*`.apps.example.krnl.es. IN A 2620:52:0:1306::10

And for Dual stack, they should resolve in both stacks depending how do you execute the dig command dig A google.com (For IPv4) or dig AAAA google.com (For IPv6)

[lahinson]

@jparrill When I move this content to the official docs, do you think it would be best if I mentioned the already existing docs about DNS as a prereq to this? I'm trying to figure out what the best way is to present this info keeping in mind that we have other docs about DNS as well.

[jparrill]

Reuse existing documentation will be always better (IMHO), only makes sense to create new doc if the case differs from the current one.

[lahinson]

@jparrill Does this warning apply only to the upstream docs, or should I include it in the official docs, too?

[jparrill]

Yes, at least until the first Z version of 4.14 get released.

[enxebre]

/approve

[openshift-ci-robot]

@jparrill: This pull request references HOSTEDCP-1184 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Which issue(s) this PR fixes:
Fixes #HOSTEDCP-1184

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bryan-cox]

/lgtm

[openshift-ci-robot]

@jparrill: This pull request references HOSTEDCP-1184 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Which issue(s) this PR fixes:
Fixes #HOSTEDCP-1184

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, enxebre, jparrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [enxebre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jparrill]

/retest-required

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 04c64ea and 2 for PR HEAD 9f2a5b5 in total

[openshift-ci]

@jparrill: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.