[release-4.14] OCPBUGS-19063: amend OLM catalogs ImageStream according to annotation #3016
Conversation
With openshift#2947 we introduced a mechanism to amend the OLM catalog ImageStream according to OpenShiftImageRegistryOverrides that are always automatically initializaed according to any ImageContentSourcePolicy (ICSP) or any ImageDigestMirrorSet (IDMS) instance from an OpenShift management cluster. But assuming that the whole default OLM catalogs got properly mirrored to a different registry just because an ICSP is there on the management cluster is overblown and with the imagestream the replacements cannot be validated ahead ot time. Let's not do it by default according to ICSP/IDMS on the management cluster but only according to the value of a new explicit annotation. Automatically mirror the 5 involved annotations from the HC CR to the HCP one. Fixes: https://issues.redhat.com/browse/OCPBUGS-18720 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-18720 has been cloned as Jira Issue OCPBUGS-19063. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/severity-critical
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-19063, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
area/control-plane-operator
|
/retest |
|
/test e2e-kubevirt-aws-ovn |
|
/override "Red Hat Trusted App Pipeline / hypershift-release-414-on-pull-request" |
|
@sjenning: Overrode contexts on behalf of sjenning: Red Hat Trusted App Pipeline / hypershift-release-414-on-pull-request In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-kubevirt-aws-ovn |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-robot
merged commit 42f796c
into
openshift:release-4.14
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-19063: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-19063 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #3001
/assign celebdor