Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-19381: Let NodePools skip min version when SkipReleaseImageValidation is in HC #3024

Merged
merged 1 commit into from Sep 21, 2023
Merged

OCPBUGS-19381: Let NodePools skip min version when SkipReleaseImageValidation is in HC #3024

merged 1 commit into from Sep 21, 2023

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Sep 19, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 19, 2023
@openshift-ci-robot
Copy link

@enxebre: This pull request references Jira Issue OCPBUGS-19381, which is invalid:

  • expected the bug to target the "4.15.0" version, but it targets "4.15" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@enxebre
Copy link
Member Author

enxebre commented Sep 19, 2023

cc @csrwng @andreadecorte

@openshift-ci openshift-ci bot added area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Sep 19, 2023
@enxebre
Copy link
Member Author

enxebre commented Sep 19, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 19, 2023
@openshift-ci-robot
Copy link

@enxebre: This pull request references Jira Issue OCPBUGS-19381, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bryan-cox
bryan-cox approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@bryan-cox bryan-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreadecorte
Copy link
Contributor

/lgtm thanks

@enxebre
Copy link
Member Author

enxebre commented Sep 19, 2023

/test e2e-kubevirt-aws-ovn

1 similar comment
@enxebre
Copy link
Member Author

enxebre commented Sep 20, 2023

/test e2e-kubevirt-aws-ovn

@enxebre
Copy link
Member Author

enxebre commented Sep 20, 2023

/override arm64-images

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2023

@enxebre: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • arm64-images

Only the following failed contexts/checkruns were expected:

  • ci/prow/arm64-images
  • ci/prow/e2e-aws
  • ci/prow/e2e-ibmcloud-iks
  • ci/prow/e2e-ibmcloud-roks
  • ci/prow/e2e-kubevirt-aws-ovn
  • ci/prow/images
  • ci/prow/unit
  • ci/prow/verify
  • netlify/hypershift-docs/deploy-preview
  • pull-ci-openshift-hypershift-main-e2e-aws
  • pull-ci-openshift-hypershift-main-e2e-ibmcloud-iks
  • pull-ci-openshift-hypershift-main-e2e-ibmcloud-roks
  • pull-ci-openshift-hypershift-main-e2e-kubevirt-aws-ovn
  • pull-ci-openshift-hypershift-main-images
  • pull-ci-openshift-hypershift-main-unit
  • pull-ci-openshift-hypershift-main-verify
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override arm64-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@enxebre
Copy link
Member Author

enxebre commented Sep 20, 2023

/override ci/prow/arm64-images

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2023

@enxebre: Overrode contexts on behalf of enxebre: ci/prow/arm64-images

In response to this:

/override ci/prow/arm64-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 13b15ae and 2 for PR HEAD 43452c7 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2023 •
edited

@enxebre: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud-roks 43452c7 link false /test e2e-ibmcloud-roks
ci/prow/arm64-images 43452c7 link true /test arm64-images
ci/prow/e2e-ibmcloud-iks 43452c7 link false /test e2e-ibmcloud-iks

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@enxebre
Copy link
Member Author

enxebre commented Sep 21, 2023

/override e2e-kubevirt-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2023

@enxebre: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • e2e-kubevirt-aws-ovn

Only the following failed contexts/checkruns were expected:

  • ci/prow/arm64-images
  • ci/prow/e2e-aws
  • ci/prow/e2e-ibmcloud-iks
  • ci/prow/e2e-ibmcloud-roks
  • ci/prow/e2e-kubevirt-aws-ovn
  • ci/prow/images
  • ci/prow/unit
  • ci/prow/verify
  • netlify/hypershift-docs/deploy-preview
  • pull-ci-openshift-hypershift-main-e2e-aws
  • pull-ci-openshift-hypershift-main-e2e-ibmcloud-iks
  • pull-ci-openshift-hypershift-main-e2e-ibmcloud-roks
  • pull-ci-openshift-hypershift-main-e2e-kubevirt-aws-ovn
  • pull-ci-openshift-hypershift-main-images
  • pull-ci-openshift-hypershift-main-unit
  • pull-ci-openshift-hypershift-main-verify
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override e2e-kubevirt-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@enxebre
Copy link
Member Author

enxebre commented Sep 21, 2023

/override pull-ci-openshift-hypershift-main-e2e-kubevirt-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2023

@enxebre: Overrode contexts on behalf of enxebre: ci/prow/e2e-kubevirt-aws-ovn

In response to this:

/override pull-ci-openshift-hypershift-main-e2e-kubevirt-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit ff8ac4e into openshift:main Sep 21, 2023
13 of 15 checks passed
@openshift-ci-robot
Copy link

@enxebre: Jira Issue OCPBUGS-19381: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-19381 has been moved to the MODIFIED state.

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryan-cox bryan-cox bryan-cox approved these changes

@hasueki hasueki Awaiting requested review from hasueki

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

Assignees

@bryan-cox bryan-cox

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@enxebre @openshift-ci-robot @andreadecorte @bryan-cox @openshift-merge-robot