Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-13829: set accesstoken-inactivity-timeout flag to openshift-oauth-apiserver #3025

Merged
merged 1 commit into from Sep 23, 2023
Merged

OCPBUGS-13829: set accesstoken-inactivity-timeout flag to openshift-oauth-apiserver #3025

merged 1 commit into from Sep 23, 2023

Conversation

sjenning
Copy link
Contributor

Standalone cluster-authentication-operator sets the accesstoken-inactivity-timeout flag on the openshift-oauth-apiserver when tokenConfig.accessTokenInactivityTimeout is set in the global OAuth config.

We pass this to oauth-openshift via the config file but not to openshift-oauth-apiserver via its flag. This results in OAuth tokens not expiring when expected.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Sep 19, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 19, 2023
@openshift-ci-robot
Copy link

@sjenning: This pull request references Jira Issue OCPBUGS-13829, which is invalid:

  • expected the bug to target the "4.15.0" version, but it targets "4.14.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Standalone cluster-authentication-operator sets the accesstoken-inactivity-timeout flag on the openshift-oauth-apiserver when tokenConfig.accessTokenInactivityTimeout is set in the global OAuth config.

We pass this to oauth-openshift via the config file but not to openshift-oauth-apiserver via its flag. This results in OAuth tokens not expiring when expected.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added do-not-merge/needs-area area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release and removed do-not-merge/needs-area labels Sep 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2023
@csrwng
Copy link
Contributor

csrwng commented Sep 19, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2023
@sjenning sjenning force-pushed the pass-inactivity-flags-oauth-server branch from b2f0d14 to 430bdbe Compare September 19, 2023 20:56
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2023
@csrwng
Copy link
Contributor

csrwng commented Sep 19, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2023
@sjenning sjenning marked this pull request as ready for review September 19, 2023 21:09
@sjenning
Copy link
Contributor Author

/jira refresh

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 19, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 19, 2023
@openshift-ci-robot
Copy link

@sjenning: This pull request references Jira Issue OCPBUGS-13829, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gkarager

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a751189 and 2 for PR HEAD 430bdbe in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 13b15ae and 1 for PR HEAD 430bdbe in total

@sjenning
Copy link
Contributor Author

/test e2e-kubevirt-aws-ovn

1 similar comment
@sjenning
Copy link
Contributor Author

/test e2e-kubevirt-aws-ovn

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ff8ac4e and 0 for PR HEAD 430bdbe in total

@openshift-ci-robot
Copy link

/hold

Revision 430bdbe was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2023
@sjenning
Copy link
Contributor Author

/hold cancel
/test e2e-kubevirt-aws-ovn

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 7fb0f42 and 2 for PR HEAD 430bdbe in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e34a1cf and 1 for PR HEAD 430bdbe in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 23, 2023

@sjenning: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 85b1bb9 into openshift:main Sep 23, 2023
12 checks passed
@openshift-ci-robot
Copy link

@sjenning: Jira Issue OCPBUGS-13829: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-13829 has been moved to the MODIFIED state.

In response to this:

Standalone cluster-authentication-operator sets the accesstoken-inactivity-timeout flag on the openshift-oauth-apiserver when tokenConfig.accessTokenInactivityTimeout is set in the global OAuth config.

We pass this to oauth-openshift via the config file but not to openshift-oauth-apiserver via its flag. This results in OAuth tokens not expiring when expected.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sjenning
Copy link
Contributor Author

/cherry-pick release-4.14

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 26, 2023
Merged
@openshift-cherrypick-robot
Copy link

@sjenning: new pull request created: #3052

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2023-09-27-073353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkarager gkarager Awaiting requested review from gkarager

@enxebre enxebre Awaiting requested review from enxebre

@hasueki hasueki Awaiting requested review from hasueki

Assignees

@csrwng csrwng

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sjenning @openshift-ci-robot @csrwng @openshift-cherrypick-robot @openshift-merge-robot