Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kubevirt] Remove EgressFirewall Creation in HCP namespace #3049

Conversation

orenc1
Copy link
Contributor

@orenc1 orenc1 commented Sep 26, 2023

Starting from 4.14, the EgressFirewall is not needed any longer, since kubevirt platform consumes the kubevirt provider in RHCOS, thus an attempt to access the metadata server is not being initiated, as opposed to the legacy OpenStack RHCOS provider.
Therefore, EgressFirewall is not needed to be deployed on the mgmt/infra cluster for guests >= v4.14.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci openshift-ci bot added area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release and removed do-not-merge/needs-area labels Sep 26, 2023
@qinqon
Copy link
Contributor

qinqon commented Sep 26, 2023

I think we can remove the egressfirewall thing altogether from hypershift >= 4.14. What do you think @davidvossel ?

@orenc1
Copy link
Contributor Author

orenc1 commented Sep 26, 2023

I think we can remove the egressfirewall thing altogether from hypershift >= 4.14. What do you think @davidvossel ?

but we have an annotation of hypershift.openshift.io/allow-unsupported-kubevirt-rhcos-variants that can potentially allow creation of guest clusters of <= 4.13.
if we'll remove it from main/4.14, users won't be able to create guest clusters of lower minor versions.

do we want to remove that escape hatch?

Starting from 4.14, the EgressFirewall is not needed any longer, since kubevirt platform consumes the kubevirt provider in RHCOS, thus an attempt to access the metadata server is not being initiated, as opposed to the legacy OpenStack RHCOS provider.
Therefore, EgressFirewall is not needed to be deployed on the mgmt/infra cluster for guests >= v4.14.

Signed-off-by: Oren Cohen <ocohen@redhat.com>
@orenc1 orenc1 force-pushed the kv_remove_egressfirewall_externalinfra branch from 6af997d to 7238421 Compare September 26, 2023 15:19
@orenc1 orenc1 changed the title [Kubevirt] Don't create EgressFirewall on external infra [Kubevirt] [Kubevirt] Remove EgressFirewall Creation in HCP namespace Sep 26, 2023
@orenc1 orenc1 changed the title [Kubevirt] [Kubevirt] Remove EgressFirewall Creation in HCP namespace [Kubevirt] Remove EgressFirewall Creation in HCP namespace Sep 26, 2023
@orenc1
Copy link
Contributor Author

orenc1 commented Sep 26, 2023

/cc @davidvossel

@openshift-ci openshift-ci bot added area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI labels Sep 26, 2023
Copy link
Contributor

@davidvossel davidvossel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel, orenc1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2023
@orenc1
Copy link
Contributor Author

orenc1 commented Sep 27, 2023

/retest

@orenc1
Copy link
Contributor Author

orenc1 commented Sep 27, 2023

INFO[2023-09-27T16:16:01Z] Step e2e-kubevirt-aws-ovn-gather-aws-console failed after 30m4s.
the tests themselves passed.
/test e2e-kubevirt-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 27, 2023

@orenc1: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 2de28b7 into openshift:main Sep 27, 2023
12 checks passed
@orenc1 orenc1 deleted the kv_remove_egressfirewall_externalinfra branch September 28, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants