Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-18341: change required pod anti-affinity rule to preferred rule #3095

Merged
merged 3 commits into from Oct 13, 2023

Conversation

rokej
Copy link
Contributor

@rokej rokej commented Oct 12, 2023

What this PR does / why we need it:
Change the hypershift operator pod anti-affinity rule from required to preferred while keeping the default replica at 2 so that the hypershift operator can be installed on SNO and can be upgraded (rolling update) on 2-node OCP cluster.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:

https://issues.redhat.com/browse/OCPBUGS-18341

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 12, 2023
@openshift-ci-robot
Copy link

@rokej: This pull request references Jira Issue OCPBUGS-18341, which is invalid:

  • expected the bug to target the "4.15.0" version, but it targets "4.14" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What this PR does / why we need it:
Change the hypershift operator pod anti-affinity rule from required to preferred while keeping the default replica at 2 so that the hypershift operator can be installed on SNO and can be upgraded (rolling update) on 2-node OCP cluster.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:

https://issues.redhat.com/browse/OCPBUGS-18341

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added area/cli Indicates the PR includes changes for CLI and removed do-not-merge/needs-area labels Oct 12, 2023
@rokej
Copy link
Contributor Author

rokej commented Oct 12, 2023

/jira refresh

@openshift-ci-robot
Copy link

@rokej: This pull request references Jira Issue OCPBUGS-18341, which is invalid:

  • expected the bug to target the "4.15.0" version, but it targets "4.14" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rokej
Copy link
Contributor Author

rokej commented Oct 12, 2023

/cherry-pick release-4.14

@openshift-cherrypick-robot

@rokej: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@jparrill jparrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @rokej.

I've tested the PR in a rootCI environment and works fine.

Dropped some comments.

Makefile Outdated Show resolved Hide resolved
Signed-off-by: Roke Jung <roke@redhat.com>
@openshift-ci openshift-ci bot added the area/ci-tooling Indicates the PR includes changes for CI or tooling label Oct 13, 2023
Signed-off-by: Roke Jung <roke@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2023

@rokej: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jparrill
Copy link
Contributor

/lgtm

@jparrill
Copy link
Contributor

/cherry-pick release-4.14

@openshift-cherrypick-robot

@jparrill: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2023
@rokej
Copy link
Contributor Author

rokej commented Oct 13, 2023

/jira refresh

@openshift-ci-robot
Copy link

@rokej: This pull request references Jira Issue OCPBUGS-18341, which is invalid:

  • expected the bug to target the "4.15.0" version, but it targets "4.14" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@davidvossel davidvossel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel, rokej

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2023
@rokej
Copy link
Contributor Author

rokej commented Oct 13, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 13, 2023
@openshift-ci-robot
Copy link

@rokej: This pull request references Jira Issue OCPBUGS-18341, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot merged commit 15c5cdd into openshift:main Oct 13, 2023
12 checks passed
@openshift-ci-robot
Copy link

@rokej: Jira Issue OCPBUGS-18341: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-18341 has been moved to the MODIFIED state.

In response to this:

What this PR does / why we need it:
Change the hypershift operator pod anti-affinity rule from required to preferred while keeping the default replica at 2 so that the hypershift operator can be installed on SNO and can be upgraded (rolling update) on 2-node OCP cluster.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:

https://issues.redhat.com/browse/OCPBUGS-18341

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@rokej: new pull request created: #3098

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants