Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-20246: Added brackets to the kubeconfig server address when IPv6 #3097

Merged
merged 1 commit into from Oct 24, 2023
Merged

OCPBUGS-20246: Added brackets to the kubeconfig server address when IPv6 #3097

merged 1 commit into from Oct 24, 2023

Conversation

jparrill
Copy link
Contributor

In order to make URLs understables by kubectl and oc clients, if the server is set as a plane IPv6 it should be surrounded by brackets (e.g https://[fd02::1]:6443)

Which issue(s) this PR fixes
Fixes #OCPBUGS-20246

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 13, 2023
@openshift-ci-robot
Copy link

@jparrill: This pull request references Jira Issue OCPBUGS-20246, which is invalid:

  • expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

In order to make URLs understables by kubectl and oc clients, if the server is set as a plane IPv6 it should be surrounded by brackets (e.g https://[fd02::1]:6443)

Which issue(s) this PR fixes
Fixes #OCPBUGS-20246

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added do-not-merge/needs-area do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release and removed do-not-merge/needs-area labels Oct 13, 2023
@jparrill jparrill marked this pull request as ready for review October 16, 2023 10:38
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2023
@jparrill
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 16, 2023
@openshift-ci-robot
Copy link

@jparrill: This pull request references Jira Issue OCPBUGS-20246, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @LiangquanLi930

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jparrill
Copy link
Contributor Author

/retest

@jparrill
OCPBUGS-20246: Added brackets to the kubeconfig server address when IPv6
373eb35 
In order to make URLs understables by kubectl and oc clients, if the server is set as a plane IPv6 it should be surrounded by brackets (e.g https://[fd02::1]:6443)

Signed-off-by: Juan Manuel Parrilla Madrid <jparrill@redhat.com>
@enxebre
Copy link
Member

enxebre commented Oct 20, 2023

thanks!
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2023
@sjenning
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD fe4fd3e and 2 for PR HEAD 373eb35 in total

@jparrill
Copy link
Contributor Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 40cde4c and 1 for PR HEAD 373eb35 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2023

@jparrill: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit ad17045 into openshift:main Oct 24, 2023
13 checks passed
@openshift-ci-robot
Copy link

@jparrill: Jira Issue OCPBUGS-20246: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-20246 has been moved to the MODIFIED state.

In response to this:

In order to make URLs understables by kubectl and oc clients, if the server is set as a plane IPv6 it should be surrounded by brackets (e.g https://[fd02::1]:6443)

Which issue(s) this PR fixes
Fixes #OCPBUGS-20246

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jparrill
Copy link
Contributor Author

/cherry-pick release-4.14

@openshift-cherrypick-robot
Copy link

@jparrill: new pull request created: #3117

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 24, 2023
Merged
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2023-10-24-230302

@openshift-ci-robot openshift-ci-robot mentioned this pull request Nov 23, 2023
Merged
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2023-11-23-205638

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjenning sjenning sjenning left review comments

@enxebre enxebre enxebre left review comments

@muraee muraee muraee left review comments

@csrwng csrwng Awaiting requested review from csrwng

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

@LiangquanLi930 LiangquanLi930 Awaiting requested review from LiangquanLi930

Assignees

@enxebre enxebre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jparrill @openshift-ci-robot @enxebre @sjenning @openshift-cherrypick-robot @openshift-merge-robot @muraee