Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-19419: change trusted bundle volume mount for CPO #3099

Merged
merged 1 commit into from Oct 16, 2023

Conversation

Patryk-Stefanski
Copy link
Contributor

What this PR does / why we need it:

Fixes issue where using a custom ca-bundle CM with a name other than user-ca-bundle would prevent the deployment of the CPO. Fixed this issue by changing the volume mount used by the deployment.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes # OCPBUGS-19419

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci openshift-ci bot added area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release and removed do-not-merge/needs-area labels Oct 14, 2023
@Patryk-Stefanski
Copy link
Contributor Author

/retest-required

@enxebre
Copy link
Member

enxebre commented Oct 16, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, Patryk-Stefanski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2023
@muraee
Copy link
Contributor

muraee commented Oct 16, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6f7f6c1 and 2 for PR HEAD 932b058 in total

@Patryk-Stefanski
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 16, 2023

@Patryk-Stefanski: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 32309b1 into openshift:main Oct 16, 2023
11 checks passed
@Patryk-Stefanski Patryk-Stefanski changed the title OCPBUGS-19419 change trusted bundle volume mount for CPO OCPBUGS-19419: change trusted bundle volume mount for CPO Oct 17, 2023
@openshift-ci-robot
Copy link

@Patryk-Stefanski: Jira Issue OCPBUGS-19419: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-19419 has been moved to the MODIFIED state.

In response to this:

What this PR does / why we need it:

Fixes issue where using a custom ca-bundle CM with a name other than user-ca-bundle would prevent the deployment of the CPO. Fixed this issue by changing the volume mount used by the deployment.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes # OCPBUGS-19419

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@celebdor
Copy link
Contributor

/cherry-pick release-4.14

@openshift-cherrypick-robot

@celebdor: new pull request created: #3102

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants