Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GITHUB_ACCESS_TOKEN requirement from release notes script #3134

Merged
merged 2 commits into from Oct 30, 2023

Conversation

muraee
Copy link
Contributor

@muraee muraee commented Oct 25, 2023

What this PR does / why we need it:
GITHUB_ACCESS_TOKEN is not required, public repos are accessible without a token.

cleanup logs to allow for an automation to directly consume the output of the command.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@muraee muraee changed the title Removd GITHUB_ACCESS_TOKEN requirement from release notes script Remove GITHUB_ACCESS_TOKEN requirement from release notes script Oct 25, 2023
@openshift-ci openshift-ci bot added area/ci-tooling Indicates the PR includes changes for CI or tooling and removed do-not-merge/needs-area labels Oct 25, 2023
@Patryk-Stefanski
Copy link
Contributor

can you update this line aswell -> https://github.com/openshift/hypershift/blob/main/docs/content/contribute/release-process.md?plain=1#L29 ?

public repos are accessible without a token
@openshift-ci openshift-ci bot added the area/documentation Indicates the PR includes changes for documentation label Oct 25, 2023
@netlify
Copy link

netlify bot commented Oct 25, 2023

Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit 4b490f0
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/65393fc4442f6a0008f797a9
😎 Deploy Preview https://deploy-preview-3134--hypershift-docs.netlify.app/contribute/release-process
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Patryk-Stefanski
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2023
allow for an automation to directly consume the output of the command.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2023
@muraee
Copy link
Contributor Author

muraee commented Oct 26, 2023

/retest-required

@enxebre
Copy link
Member

enxebre commented Oct 26, 2023

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2023
Copy link
Member

@bryan-cox bryan-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, enxebre, muraee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 41e3cf9 and 2 for PR HEAD 8349874 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a70b9a5 and 1 for PR HEAD 8349874 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD eca17b6 and 0 for PR HEAD 8349874 in total

@openshift-ci-robot
Copy link

/hold

Revision 8349874 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2023
@muraee
Copy link
Contributor Author

muraee commented Oct 30, 2023

/retest-required

@muraee
Copy link
Contributor Author

muraee commented Oct 30, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 30, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2023

@muraee: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 87a6868 into openshift:main Oct 30, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci-tooling Indicates the PR includes changes for CI or tooling area/documentation Indicates the PR includes changes for documentation lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants