Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.14] OCPBUGS-22690: Use the same etcd snapshot for all replicas during etcd restore #3146

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #3081

/assign muraee

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 30, 2023

@openshift-cherrypick-robot: An error was encountered cloning bug for cherrypick for bug HOSTEDCP-1215 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message. request failed. Please analyze the request body for more details. Status code: 400: {"errorMessages":["Number value expected as the Sprint id."],"errors":{"customfield_12319749":"Operation value must be a string","customfield_12319751":"Operation value must be a string"}}

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

This is an automated cherry-pick of #3081

/assign muraee

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@muraee
Copy link
Contributor

muraee commented Oct 30, 2023

/retitle [release-4.14] OCPBUGS-22690: Use the same etcd snapshot for all replicas during etcd restore

@openshift-ci openshift-ci bot changed the title [release-4.14] HOSTEDCP-1215: Use the same etcd snapshot for all replicas during etcd restore [release-4.14] OCPBUGS-22690: Use the same etcd snapshot for all replicas during etcd restore Oct 30, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 30, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 30, 2023

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-22690, which is invalid:

  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • bug has dependents
  • dependent bug HOSTEDCP-1215 is not in the required OCPBUGS project

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #3081

/assign muraee

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 30, 2023
@openshift-ci openshift-ci bot requested review from csrwng and enxebre October 30, 2023 15:54
@openshift-ci openshift-ci bot added area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/documentation Indicates the PR includes changes for documentation area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release and removed do-not-merge/needs-area labels Oct 30, 2023
@muraee
Copy link
Contributor

muraee commented Oct 30, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 30, 2023
@openshift-ci-robot
Copy link

@muraee: This pull request references Jira Issue OCPBUGS-22690, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-22693 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-22693 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2023

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud-roks 108e67e link false /test e2e-ibmcloud-roks
ci/prow/e2e-ibmcloud-iks 108e67e link false /test e2e-ibmcloud-iks

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jparrill
Copy link
Contributor

jparrill commented Nov 2, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2023
@sjenning
Copy link
Contributor

sjenning commented Nov 7, 2023

/approve
/override "Red Hat Trusted App Pipeline / hypershift-release-414-on-pull-request"

Copy link
Contributor

openshift-ci bot commented Nov 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2023
Copy link
Contributor

openshift-ci bot commented Nov 7, 2023

@sjenning: Overrode contexts on behalf of sjenning: Red Hat Trusted App Pipeline / hypershift-release-414-on-pull-request

In response to this:

/approve
/override "Red Hat Trusted App Pipeline / hypershift-release-414-on-pull-request"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit f1acb05 into openshift:release-4.14 Nov 7, 2023
7 of 10 checks passed
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-22690: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-22690 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #3081

/assign muraee

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.14.0-0.nightly-2023-11-08-004805

@enxebre
Copy link
Member

enxebre commented Nov 16, 2023

/cherry-pick release-4.13

@openshift-cherrypick-robot
Copy link
Author

@enxebre: #3146 failed to apply on top of branch "release-4.13":

Applying: limit RestoreSnapshotURL api field to 1 entry
Using index info to reconstruct a base tree...
M	api/v1alpha1/hostedcluster_types.go
M	api/v1beta1/hostedcluster_types.go
M	cmd/install/assets/hypershift-operator/hypershift.openshift.io_hostedclusters.yaml
M	cmd/install/assets/hypershift-operator/hypershift.openshift.io_hostedcontrolplanes.yaml
M	control-plane-operator/controllers/hostedcontrolplane/etcd/reconcile.go
M	control-plane-operator/controllers/hostedcontrolplane/etcd/reconcile_test.go
M	docs/content/reference/api.md
M	hack/app-sre/saas_template.yaml
Falling back to patching base and 3-way merge...
Auto-merging hack/app-sre/saas_template.yaml
Auto-merging docs/content/reference/api.md
Auto-merging control-plane-operator/controllers/hostedcontrolplane/etcd/reconcile_test.go
CONFLICT (content): Merge conflict in control-plane-operator/controllers/hostedcontrolplane/etcd/reconcile_test.go
Auto-merging control-plane-operator/controllers/hostedcontrolplane/etcd/reconcile.go
Auto-merging cmd/install/assets/hypershift-operator/hypershift.openshift.io_hostedcontrolplanes.yaml
Auto-merging cmd/install/assets/hypershift-operator/hypershift.openshift.io_hostedclusters.yaml
Auto-merging api/v1beta1/hostedcluster_types.go
CONFLICT (content): Merge conflict in api/v1beta1/hostedcluster_types.go
Auto-merging api/v1alpha1/hostedcluster_types.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 limit RestoreSnapshotURL api field to 1 entry
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/documentation Indicates the PR includes changes for documentation area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants