New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-JIRA: Add --auto-repair flag to hcp create nodepool
#3163
NO-JIRA: Add --auto-repair flag to hcp create nodepool
#3163
Conversation
Signed-off-by: David Vossel <davidvossel@gmail.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidvossel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hcp create nodepool
hcp create nodepool
@davidvossel: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/lgtm |
/test e2e-kubevirt-aws-ovn |
/test e2e-kubevirt-aws-ovn |
@davidvossel: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-hypershift-container-v4.16.0-202403290310.p0.g8dc2f60.assembly.stream.el9 for distgit hypershift. |
The
--auto-repair
flag is already present duringhcp create cluster...
however this value is not present when creating a new nodepool for an existing cluster. This PR addresses that by bringing parity to the cli nodepool creation.