Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Add --auto-repair flag to hcp create nodepool #3163

Merged
merged 1 commit into from Mar 29, 2024

Conversation

davidvossel
Copy link
Contributor

The --auto-repair flag is already present during hcp create cluster... however this value is not present when creating a new nodepool for an existing cluster. This PR addresses that by bringing parity to the cli nodepool creation.

Signed-off-by: David Vossel <davidvossel@gmail.com>
@openshift-ci openshift-ci bot added area/cli Indicates the PR includes changes for CLI and removed do-not-merge/needs-area labels Nov 3, 2023
Copy link
Contributor

openshift-ci bot commented Nov 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2023
@davidvossel davidvossel changed the title Add --auto-repair flag to hcp create nodepool NO-JIRA: Add --auto-repair flag to hcp create nodepool Feb 1, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 1, 2024
@openshift-ci-robot
Copy link

@davidvossel: This pull request explicitly references no jira issue.

In response to this:

The --auto-repair flag is already present during hcp create cluster... however this value is not present when creating a new nodepool for an existing cluster. This PR addresses that by bringing parity to the cli nodepool creation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bryan-cox
Copy link
Member

/lgtm

@bryan-cox
Copy link
Member

/test e2e-kubevirt-aws-ovn

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2024
@bryan-cox
Copy link
Member

/test e2e-kubevirt-aws-ovn

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9b66e19 and 2 for PR HEAD 71e1215 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d140126 and 1 for PR HEAD 71e1215 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6401390 and 0 for PR HEAD 71e1215 in total

Copy link
Contributor

openshift-ci bot commented Mar 29, 2024

@davidvossel: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 8dc2f60 into openshift:main Mar 29, 2024
11 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-hypershift-container-v4.16.0-202403290310.p0.g8dc2f60.assembly.stream.el9 for distgit hypershift.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cli Indicates the PR includes changes for CLI jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants