Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-22912: Set value of elb tag to 1 instead of true #3198

Merged
merged 1 commit into from Nov 16, 2023

Conversation

csrwng
Copy link
Contributor

@csrwng csrwng commented Nov 15, 2023

What this PR does / why we need it:
The value of the kubernetes.io/role/elb and
kubernetes.io/role/internal-elb tag should be '1' and not 'true'. Ref:
https://github.com/openshift/aws-load-balancer-operator/blob/main/docs/prerequisites.md#subnets

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #OCPBUGS-22912

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

The value of the kubernetes.io/role/elb and
kubernetes.io/role/internal-elb tag should be '1' and not 'true'.
Ref:
https://github.com/openshift/aws-load-balancer-operator/blob/main/docs/prerequisites.md#subnets
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 15, 2023
@openshift-ci-robot
Copy link

@csrwng: This pull request references Jira Issue OCPBUGS-22912, which is invalid:

  • expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What this PR does / why we need it:
The value of the kubernetes.io/role/elb and
kubernetes.io/role/internal-elb tag should be '1' and not 'true'. Ref:
https://github.com/openshift/aws-load-balancer-operator/blob/main/docs/prerequisites.md#subnets

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #OCPBUGS-22912

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csrwng
Copy link
Contributor Author

csrwng commented Nov 15, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 15, 2023
@openshift-ci-robot
Copy link

@csrwng: This pull request references Jira Issue OCPBUGS-22912, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the area/cli Indicates the PR includes changes for CLI label Nov 15, 2023
Copy link
Contributor

openshift-ci bot commented Nov 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Nov 15, 2023
@enxebre
Copy link
Member

enxebre commented Nov 15, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 7b010b9 and 2 for PR HEAD d14a2f4 in total

Copy link
Contributor

openshift-ci bot commented Nov 16, 2023

@csrwng: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 8e70f2b into openshift:main Nov 16, 2023
11 checks passed
@openshift-ci-robot
Copy link

@csrwng: Jira Issue OCPBUGS-22912: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-22912 has been moved to the MODIFIED state.

In response to this:

What this PR does / why we need it:
The value of the kubernetes.io/role/elb and
kubernetes.io/role/internal-elb tag should be '1' and not 'true'. Ref:
https://github.com/openshift/aws-load-balancer-operator/blob/main/docs/prerequisites.md#subnets

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #OCPBUGS-22912

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-hypershift-container-v4.15.0-202311160409.p0.g8e70f2b.assembly.stream for distgit hypershift.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2023-11-16-090456

@csrwng csrwng deleted the fix_elb_tag branch November 21, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cli Indicates the PR includes changes for CLI jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants