Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-23511: Remove IAM path when applying control-plane-operator ARN to VPC Endpoint Service allowed principals #3215

Merged
merged 1 commit into from Dec 11, 2023
Merged

OCPBUGS-23511: Remove IAM path when applying control-plane-operator ARN to VPC Endpoint Service allowed principals #3215

merged 1 commit into from Dec 11, 2023

Conversation

mjlshen
Copy link
Contributor

@mjlshen mjlshen commented Nov 21, 2023 •
edited

What this PR does / why we need it:
Confusingly, AWS arns that include a path are not valid IAM principals, the path needs to be removed before they are applied to VPC Endpoint Service additional allowed principals.

Which issue(s) this PR fixes:
Fixes OCPBUGS-23511

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

/area hypershift-operator

@openshift-ci openshift-ci bot added area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release and removed do-not-merge/needs-area labels Nov 21, 2023
@mjlshen mjlshen changed the title Remove IAM path when applying control-plane-operator ARN to VPC Endpoint Service allowed principals OCPBUGS-23511: Remove IAM path when applying control-plane-operator ARN to VPC Endpoint Service allowed principals Nov 21, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 21, 2023
@openshift-ci-robot
Copy link

@mjlshen: This pull request references Jira Issue OCPBUGS-23511, which is invalid:

  • expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What this PR does / why we need it:
Confusingly, AWS arns that include a path are not valid IAM principals, the path needs to be removed before they are applied to VPC Endpoint Service additional allowed principals.

Which issue(s) this PR fixes:
Fixes OCPBUGS-23511

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

/area hypershift-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjlshen
Copy link
Contributor Author

mjlshen commented Nov 21, 2023

/test e2e-aws

@mjlshen
Copy link
Contributor Author

mjlshen commented Nov 21, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 21, 2023
@openshift-ci-robot
Copy link

@mjlshen: This pull request references Jira Issue OCPBUGS-23511, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andreadecorte
Copy link
Contributor

lgtm

@mjlshen
Remove IAM path when applying control-plane-operator ARN to VPC Endpo…
feb68b2 
…int Service allowed principals

Confusingly, AWS arns that include a path are not valid IAM principals,
the path needs to be removed before they are applied to VPC Endpoint
Service additional allowed principals.

Signed-off-by: Michael Shen <mshen@redhat.com>
@mjlshen mjlshen requested a review from enxebre November 23, 2023 15:27
@csrwng
Copy link
Contributor

csrwng commented Nov 27, 2023

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, mjlshen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2023
@Patryk-Stefanski
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2023
@mjlshen
Copy link
Contributor Author

mjlshen commented Dec 8, 2023

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6315b72 and 2 for PR HEAD feb68b2 in total

@mjlshen
Copy link
Contributor Author

mjlshen commented Dec 8, 2023

/retest-required

1 similar comment
@mjlshen
Copy link
Contributor Author

mjlshen commented Dec 8, 2023

/retest-required

@mjlshen
Copy link
Contributor Author

mjlshen commented Dec 9, 2023

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD bcb3e90 and 1 for PR HEAD feb68b2 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 0952c61 and 0 for PR HEAD feb68b2 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 11, 2023

@mjlshen: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 211563d into openshift:main Dec 11, 2023
12 checks passed
@openshift-ci-robot
Copy link

@mjlshen: Jira Issue OCPBUGS-23511: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-23511 has been moved to the MODIFIED state.

In response to this:

What this PR does / why we need it:
Confusingly, AWS arns that include a path are not valid IAM principals, the path needs to be removed before they are applied to VPC Endpoint Service additional allowed principals.

Which issue(s) this PR fixes:
Fixes OCPBUGS-23511

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

/area hypershift-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjlshen mjlshen deleted the OCPBUGS-23511 branch December 11, 2023 23:05
@mjlshen
Copy link
Contributor Author

mjlshen commented Jan 16, 2024

/cherry-pick release-4.14

@openshift-cherrypick-robot
Copy link

@mjlshen: new pull request created: #3431

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csrwng csrwng csrwng left review comments

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

@sjenning sjenning Awaiting requested review from sjenning

@enxebre enxebre Awaiting requested review from enxebre

Assignees

@Patryk-Stefanski Patryk-Stefanski

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mjlshen @openshift-ci-robot @andreadecorte @csrwng @Patryk-Stefanski @openshift-cherrypick-robot @enxebre