Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-23921: Use correct kubeconfig in CCM and remove CCMs access t… #3222

Merged
merged 1 commit into from Nov 24, 2023

Conversation

Patryk-Stefanski
Copy link
Contributor

What this PR does / why we need it:

  • CCM used in cluster config to retrieve the client rather than guest kubeconfig which causes CCM to rely on management KAS access. This PR adds args to use guest kubeconfig to retrieve the client which doesnt need management KAS.

Which issue(s) this PR fixes
Fixes #HOSTEDCP-1282

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 22, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 22, 2023

@Patryk-Stefanski: This pull request references HOSTEDCP-1282 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.15.0" version, but no target version was set.

In response to this:

What this PR does / why we need it:

  • CCM used in cluster config to retrieve the client rather than guest kubeconfig which causes CCM to rely on management KAS access. This PR adds args to use guest kubeconfig to retrieve the client which doesnt need management KAS.

Which issue(s) this PR fixes
Fixes #HOSTEDCP-1282

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release and removed do-not-merge/needs-area labels Nov 22, 2023
@Patryk-Stefanski
Copy link
Contributor Author

/retest-required

@Patryk-Stefanski
Copy link
Contributor Author

/retest-required

@Patryk-Stefanski
Copy link
Contributor Author

/test e2e-aws

1 similar comment
@Patryk-Stefanski
Copy link
Contributor Author

/test e2e-aws

@enxebre
Copy link
Member

enxebre commented Nov 24, 2023

/approve
/cherry-pick release-4.14

@openshift-cherrypick-robot

@enxebre: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/approve
/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Nov 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, Patryk-Stefanski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2023
@celebdor
Copy link
Contributor

/retitle OCPBUGS-23921: Use correct kubeconfig in CCM and remove CCMs access to the Management Cluster

@openshift-ci openshift-ci bot changed the title HOSTEDCP-1282: Use correct kubeconfig in CCM and remove CCMs access t… OCPBUGS-23921: Use correct kubeconfig in CCM and remove CCMs access to the Management Cluster Nov 24, 2023
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 24, 2023
@openshift-ci-robot
Copy link

@Patryk-Stefanski: This pull request references Jira Issue OCPBUGS-23921, which is invalid:

  • expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What this PR does / why we need it:

  • CCM used in cluster config to retrieve the client rather than guest kubeconfig which causes CCM to rely on management KAS access. This PR adds args to use guest kubeconfig to retrieve the client which doesnt need management KAS.

Which issue(s) this PR fixes
Fixes #HOSTEDCP-1282

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Patryk-Stefanski Patryk-Stefanski changed the title OCPBUGS-23921: Use correct kubeconfig in CCM and remove CCMs access to the Management Cluster OCPBUGS-23921: Use correct kubeconfig in CCM and remove CCMs access t… Nov 24, 2023
@Patryk-Stefanski
Copy link
Contributor Author

/jira refresh

1 similar comment
@celebdor
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link

@celebdor: An error was encountered updating to the POST state for bug OCPBUGS-23921 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message. Error marking step #30670643 finished: root cause: Tried to update an entity that does not exist.: request failed. Please analyze the request body for more details. Status code: 400:

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Nov 24, 2023
@openshift-ci-robot
Copy link

@Patryk-Stefanski: This pull request references Jira Issue OCPBUGS-23921, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 24, 2023
@Patryk-Stefanski
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@Patryk-Stefanski: This pull request references Jira Issue OCPBUGS-23921, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jparrill
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2023
Copy link
Contributor

openshift-ci bot commented Nov 24, 2023

@Patryk-Stefanski: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 6dad4fc into openshift:main Nov 24, 2023
12 checks passed
@openshift-ci-robot
Copy link

@Patryk-Stefanski: Jira Issue OCPBUGS-23921: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-23921 has been moved to the MODIFIED state.

In response to this:

What this PR does / why we need it:

  • CCM used in cluster config to retrieve the client rather than guest kubeconfig which causes CCM to rely on management KAS access. This PR adds args to use guest kubeconfig to retrieve the client which doesnt need management KAS.

Which issue(s) this PR fixes
Fixes #HOSTEDCP-1282

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@enxebre: new pull request created: #3232

In response to this:

/approve
/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-hypershift-container-v4.15.0-202311241809.p0.g6dad4fc.assembly.stream for distgit hypershift.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2023-11-24-210138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants