Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] CCO-388: control-plane-operator: reconcile the CCO (rebased) #3260

Closed
wants to merge 5 commits into from
Closed

[WIP] CCO-388: control-plane-operator: reconcile the CCO (rebased) #3260

wants to merge 5 commits into from

Conversation

perdasilva
Copy link

Rebased copy of #2794

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 30, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 30, 2023 •
edited by openshift-ci bot

@perdasilva: This pull request references CCO-388 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Rebased copy of #2794

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added do-not-merge/needs-area do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 30, 2023
@perdasilva
Copy link
Author

trying to turn over CI sans feature gating

@openshift-ci openshift-ci bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/testing Indicates the PR includes changes for e2e testing labels Nov 30, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: perdasilva
Once this PR has been reviewed and has the lgtm label, please assign sjenning for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

stevekuznetsov and others added 4 commits December 1, 2023 13:28
@stevekuznetsov
control-plane-operator: reconcile the CCO
92be95d 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
comments out FG check
1200187 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
update cco deployment unit test fixture
0c6c38a 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
wrap cco reconciliation around platform type check
8d78368 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
disable cco reconciliation and test ci
e1821bd 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 2, 2023

@perdasilva: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify e1821bd link true /test verify
ci/prow/e2e-kubevirt-aws-ovn e1821bd link true /test e2e-kubevirt-aws-ovn
ci/prow/e2e-aws e1821bd link true /test e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevekuznetsov
Copy link
Contributor

/close

@openshift-ci openshift-ci bot closed this Dec 8, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 8, 2023

@stevekuznetsov: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasueki hasueki Awaiting requested review from hasueki

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

Assignees
No one assigned
Labels
area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/testing Indicates the PR includes changes for e2e testing do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@perdasilva @openshift-ci-robot @stevekuznetsov