MULTIARCH-3882: Support PER solution for powervs platform via transit gateway #3277

dharaneeshvrd · 2023-12-04T14:02:26Z

More about PER: https://cloud.ibm.com/docs/power-iaas?topic=power-iaas-per

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

Subject and description added to both, commit and PR.
Relevant issues have been referenced.
This change includes docs.
This change includes unit tests.

openshift-ci-robot · 2023-12-04T14:02:30Z

@dharaneeshvrd: This pull request references MULTIARCH-3882 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

More about PER: https://cloud.ibm.com/docs/power-iaas?topic=power-iaas-per

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

netlify · 2023-12-04T14:03:25Z

✅ Deploy Preview for hypershift-docs ready!

Name	Link
🔨 Latest commit	`e558df6`
🔍 Latest deploy log	https://app.netlify.com/sites/hypershift-docs/deploys/65bbaa2362108100083451ed
😎 Deploy Preview	https://deploy-preview-3277--hypershift-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dharaneeshvrd · 2023-12-05T04:51:38Z

/retest-required

dharaneeshvrd · 2023-12-05T04:55:41Z

/cc @mkumatag

csrwng · 2023-12-11T14:31:47Z

Can you please separate the vendor file changes into a separate commit?

mkumatag · 2024-01-09T05:08:23Z

cmd/cluster/core/create.go

+	VPCSubnet              string
+	Debug                  bool
+	RecreateSecrets        bool
+	UsePER                 bool


These fields are increasing, lets start adding comments for these fields to have better understanding

mkumatag · 2024-01-09T05:09:21Z

cmd/cluster/powervs/create.go

@@ -50,6 +51,9 @@ func NewCreateCommand(opts *core.CreateOptions) *cobra.Command {
 	cmd.Flags().Int32Var(&opts.PowerVSPlatform.Memory, "memory", opts.PowerVSPlatform.Memory, "Amount of memory allocated (in GB). Default is 32")
 	cmd.Flags().BoolVar(&opts.PowerVSPlatform.Debug, "debug", opts.PowerVSPlatform.Debug, "Enabling this will print PowerVS API Request & Response logs")
 	cmd.Flags().BoolVar(&opts.PowerVSPlatform.RecreateSecrets, "recreate-secrets", opts.PowerVSPlatform.RecreateSecrets, "Enabling this flag will recreate creds mentioned https://hypershift-docs.netlify.app/reference/api/#hypershift.openshift.io/v1alpha1.PowerVSPlatformSpec here. This is required when rerunning 'hypershift create cluster powervs' or 'hypershift create infra powervs' commands, since API key once created cannot be retrieved again. Please make sure that cluster name used is unique across different management clusters before using this flag")
+	cmd.Flags().BoolVar(&opts.PowerVSPlatform.UsePER, "use-per", opts.PowerVSPlatform.UsePER, "Enabling this flag will utilize PER solution via transit gateway instead of cloud connection to create a connection between PowerVS and VPC")


can we change the name to power-edge-router

mkumatag · 2024-01-09T05:10:16Z

cmd/cluster/powervs/destroy.go

@@ -39,12 +40,16 @@ func NewDestroyCommand(opts *core.DestroyOptions) *cobra.Command {
 	cmd.Flags().StringVar(&opts.PowerVSPlatform.CloudInstanceID, "cloud-instance-id", "", "IBM Cloud PowerVS Service Instance ID. Use this flag to reuse an existing PowerVS Service Instance resource for cluster's infra")
 	cmd.Flags().StringVar(&opts.PowerVSPlatform.CloudConnection, "cloud-connection", "", "Cloud Connection in given zone. Use this flag to reuse an existing Cloud Connection resource for cluster's infra")
 	cmd.Flags().BoolVar(&opts.PowerVSPlatform.Debug, "debug", opts.PowerVSPlatform.Debug, "Enabling this will print PowerVS API Request & Response logs")
+	cmd.Flags().BoolVar(&opts.PowerVSPlatform.UsePER, "use-per", opts.PowerVSPlatform.UsePER, "Enabling this flag will utilize PER solution via transit gateway instead of cloud connection to create a connection between PowerVS and VPC")


same comment as above

mkumatag · 2024-01-09T05:11:04Z

cmd/infra/powervs/create.go

@@ -218,12 +228,16 @@ func NewCreateCommand() *cobra.Command {
 	cmd.Flags().StringVar(&opts.OutputFile, "output-file", opts.OutputFile, "Path to file that will contain output information from infra resources (optional)")
 	cmd.Flags().BoolVar(&opts.Debug, "debug", opts.Debug, "Enabling this will print PowerVS API Request & Response logs")
 	cmd.Flags().BoolVar(&opts.RecreateSecrets, "recreate-secrets", opts.RecreateSecrets, "Enabling this flag will recreate creds mentioned https://hypershift-docs.netlify.app/reference/api/#hypershift.openshift.io/v1alpha1.PowerVSPlatformSpec here. This is required when rerunning 'hypershift create cluster powervs' or 'hypershift create infra powervs' commands, since API key once created cannot be retrieved again. Please make sure that cluster name used is unique across different management clusters before using this flag")
+	cmd.Flags().BoolVar(&opts.UsePER, "use-per", opts.UsePER, "Enabling this flag will utilize PER solution via transit gateway instead of cloud connection to create a connection between PowerVS and VPC")


same as above

mkumatag · 2024-01-09T05:14:41Z

cmd/infra/powervs/create.go

+	if transitGateway != nil {
+		infra.TransitGatewayID = *transitGateway.ID
+		infra.Stats.TransitGatewayState.Status = *transitGateway.Status
+	} else {
+		return fmt.Errorf("unable to setup transit gateway")
+	}


Suggested change

if transitGateway != nil {

infra.TransitGatewayID = *transitGateway.ID

infra.Stats.TransitGatewayState.Status = *transitGateway.Status

} else {

return fmt.Errorf("unable to setup transit gateway")

}

if transitGateway == nil {

return fmt.Errorf("unable to setup transit gateway")

}

infra.TransitGatewayID = *transitGateway.ID

infra.Stats.TransitGatewayState.Status = *transitGateway.Status

mkumatag · 2024-01-09T05:18:13Z

cmd/infra/powervs/create.go

+	if err != nil && err.Error() != transitGatewayNotFound(transitGatewayName).Error() {
+		return nil, fmt.Errorf("error validating existing transit gateway: %w", err)
+	}
+	if tg != nil && *tg.Status == "available" {


Is there a scenario where tg is not nil and status is not in available state then what happens? Ideally even a create call also should fail as tg already exists, then how do we handle that scenario?

Yes, when validateTransitGatewayByName returns transitGatewayNotFound error, tg would be nil, so before accessing *tg.status, need to validate it's not nil. If its nil, will proceed to create a new transit gatway. So we need a nil check here. We will not attempt the create if its already exists.

what if tg is not null(transit gateway exist) and state is not available?

Yeah that's a possible case, now handled in validateTransitGatewayByName func itself, when tg exists and it is not in available state will return transitGatewayUnavailableError. Thanks for the catch

mkumatag · 2024-01-09T05:20:08Z

cmd/infra/powervs/create.go

+	}
+	if tg != nil && *tg.Status == "available" {
+		log(options.InfraID).Info("Using existing transit gateway ...")
+		return tg, nil


if available the does it mean that we also have connections as well? what if we just have the transit gateway but not the connections for vpc and powervs?

I am validating the vpc and powervs connections are attached to this tg and their status is ok in validateTransitGatewayByName func. Then only I would return the tg obj. If tg is there and connections are not proper then I return transitGatewayConnectionError.

mkumatag · 2024-01-09T05:20:53Z

cmd/infra/powervs/destroy.go

@@ -99,6 +103,9 @@ func NewDestroyCommand() *cobra.Command {
 	cmd.Flags().StringVar(&opts.CloudConnection, "cloud-connection", opts.CloudConnection, "IBM Cloud PowerVS Cloud Connection. Use this flag to reuse an existing Cloud Connection resource for cluster's infra")
 	cmd.Flags().StringVar(&opts.CloudInstanceID, "cloud-instance-id", opts.CloudInstanceID, "IBM PowerVS Cloud Instance ID. Use this flag to reuse an existing PowerVS Cloud Instance resource for cluster's infra")
 	cmd.Flags().BoolVar(&opts.Debug, "debug", opts.Debug, "Enabling this will result in debug logs will be printed")
+	cmd.Flags().BoolVar(&opts.UsePER, "use-per", opts.UsePER, "Enabling this flag will utilize PER solution via transit gateway instead of cloud connection to create a connection between PowerVS and VPC")


same as above

dharaneeshvrd

@mkumatag
I have addressed your other comments too, please take a look!

dharaneeshvrd · 2024-01-11T14:42:50Z

cmd/infra/powervs/create.go

+	if err != nil && err.Error() != transitGatewayNotFound(transitGatewayName).Error() {
+		return nil, fmt.Errorf("error validating existing transit gateway: %w", err)
+	}
+	if tg != nil && *tg.Status == "available" {


Yes, when validateTransitGatewayByName returns transitGatewayNotFound error, tg would be nil, so before accessing *tg.status, need to validate it's not nil. If its nil, will proceed to create a new transit gatway. So we need a nil check here. We will not attempt the create if its already exists.

dharaneeshvrd · 2024-01-11T14:47:14Z

cmd/infra/powervs/create.go

+	}
+	if tg != nil && *tg.Status == "available" {
+		log(options.InfraID).Info("Using existing transit gateway ...")
+		return tg, nil


I am validating the vpc and powervs connections are attached to this tg and their status is ok in validateTransitGatewayByName func. Then only I would return the tg obj. If tg is there and connections are not proper then I return transitGatewayConnectionError.

mkumatag · 2024-01-18T04:41:45Z

cmd/cluster/core/create.go

 	CloudConnection string
-	VPCRegion       string
-	VPC             string
-	VPCSubnet       string


I see this VPCSubnet is missing, is this intentionally removed?

Yes, its unused, so removed it.

mkumatag · 2024-01-18T04:49:58Z

cmd/cluster/powervs/destroy.go

@@ -39,12 +40,16 @@ func NewDestroyCommand(opts *core.DestroyOptions) *cobra.Command {
 	cmd.Flags().StringVar(&opts.PowerVSPlatform.CloudInstanceID, "cloud-instance-id", "", "IBM Cloud PowerVS Service Instance ID. Use this flag to reuse an existing PowerVS Service Instance resource for cluster's infra")
 	cmd.Flags().StringVar(&opts.PowerVSPlatform.CloudConnection, "cloud-connection", "", "Cloud Connection in given zone. Use this flag to reuse an existing Cloud Connection resource for cluster's infra")
 	cmd.Flags().BoolVar(&opts.PowerVSPlatform.Debug, "debug", opts.PowerVSPlatform.Debug, "Enabling this will print PowerVS API Request & Response logs")
+	cmd.Flags().BoolVar(&opts.PowerVSPlatform.UsePER, "use-power-edge-router", opts.PowerVSPlatform.UsePER, "Enabling this flag will denotes that Power Edge Router solution is used while creating the cluster")


Suggested change

cmd.Flags().BoolVar(&opts.PowerVSPlatform.UsePER, "use-power-edge-router", opts.PowerVSPlatform.UsePER, "Enabling this flag will denotes that Power Edge Router solution is used while creating the cluster")

cmd.Flags().BoolVar(&opts.PowerVSPlatform.PER, "power-edge-router", opts.PowerVSPlatform.PER, "Enabling this flag will denotes that Power Edge Router solution is used while creating the cluster")

mkumatag · 2024-01-18T04:50:41Z

cmd/cluster/powervs/create.go

@@ -50,6 +51,9 @@ func NewCreateCommand(opts *core.CreateOptions) *cobra.Command {
 	cmd.Flags().Int32Var(&opts.PowerVSPlatform.Memory, "memory", opts.PowerVSPlatform.Memory, "Amount of memory allocated (in GB). Default is 32")
 	cmd.Flags().BoolVar(&opts.PowerVSPlatform.Debug, "debug", opts.PowerVSPlatform.Debug, "Enabling this will print PowerVS API Request & Response logs")
 	cmd.Flags().BoolVar(&opts.PowerVSPlatform.RecreateSecrets, "recreate-secrets", opts.PowerVSPlatform.RecreateSecrets, "Enabling this flag will recreate creds mentioned https://hypershift-docs.netlify.app/reference/api/#hypershift.openshift.io/v1alpha1.PowerVSPlatformSpec here. This is required when rerunning 'hypershift create cluster powervs' or 'hypershift create infra powervs' commands, since API key once created cannot be retrieved again. Please make sure that cluster name used is unique across different management clusters before using this flag")
+	cmd.Flags().BoolVar(&opts.PowerVSPlatform.UsePER, "use-power-edge-router", opts.PowerVSPlatform.UsePER, "Enabling this flag will utilize Power Edge Router solution via transit gateway instead of cloud connection to create a connection between PowerVS and VPC")


Suggested change

cmd.Flags().BoolVar(&opts.PowerVSPlatform.UsePER, "use-power-edge-router", opts.PowerVSPlatform.UsePER, "Enabling this flag will utilize Power Edge Router solution via transit gateway instead of cloud connection to create a connection between PowerVS and VPC")

cmd.Flags().BoolVar(&opts.PowerVSPlatform.PER, "power-edge-router", opts.PowerVSPlatform.PER, "Enabling this flag will utilize Power Edge Router solution via transit gateway instead of cloud connection to create a connection between PowerVS and VPC")

mkumatag · 2024-01-18T04:53:09Z

cmd/infra/powervs/create.go

@@ -218,12 +228,16 @@ func NewCreateCommand() *cobra.Command {
 	cmd.Flags().StringVar(&opts.OutputFile, "output-file", opts.OutputFile, "Path to file that will contain output information from infra resources (optional)")
 	cmd.Flags().BoolVar(&opts.Debug, "debug", opts.Debug, "Enabling this will print PowerVS API Request & Response logs")
 	cmd.Flags().BoolVar(&opts.RecreateSecrets, "recreate-secrets", opts.RecreateSecrets, "Enabling this flag will recreate creds mentioned https://hypershift-docs.netlify.app/reference/api/#hypershift.openshift.io/v1alpha1.PowerVSPlatformSpec here. This is required when rerunning 'hypershift create cluster powervs' or 'hypershift create infra powervs' commands, since API key once created cannot be retrieved again. Please make sure that cluster name used is unique across different management clusters before using this flag")
+	cmd.Flags().BoolVar(&opts.UsePER, "use-power-edge-router", opts.UsePER, "Enabling this flag will utilize Power Edge Router solution via transit gateway instead of cloud connection to create a connection between PowerVS and VPC")


Suggested change

cmd.Flags().BoolVar(&opts.UsePER, "use-power-edge-router", opts.UsePER, "Enabling this flag will utilize Power Edge Router solution via transit gateway instead of cloud connection to create a connection between PowerVS and VPC")

cmd.Flags().BoolVar(&opts.PER, "power-edge-router", opts.PER, "Enabling this flag will utilize Power Edge Router solution via transit gateway instead of cloud connection to create a connection between PowerVS and VPC")

mkumatag · 2024-01-18T04:53:45Z

cmd/infra/powervs/create.go

-	if err = infra.setupPowerVSCloudConnection(ctx, options, session, gtag); err != nil {
-		return fmt.Errorf("error setup powervs cloud connection: %w", err)
+	if options.UsePER {
+		if err = infra.setupTransitGateway(ctx, options, gtag); err != nil {


Suggested change

if err = infra.setupTransitGateway(ctx, options, gtag); err != nil {

if err := infra.setupTransitGateway(ctx, options, gtag); err != nil {

mkumatag · 2024-01-18T04:54:49Z

cmd/infra/powervs/create.go

-	if err = infra.isCloudConnectionReady(ctx, options, session); err != nil {
-		return fmt.Errorf("cloud connection is not up: %w", err)
+	if !options.UsePER {
+		if err = infra.isCloudConnectionReady(ctx, options, session); err != nil {


Suggested change

if err = infra.isCloudConnectionReady(ctx, options, session); err != nil {

if err := infra.isCloudConnectionReady(ctx, options, session); err != nil {

mkumatag · 2024-01-18T04:57:00Z

cmd/infra/powervs/create.go

+	infra.TransitGatewayID = *transitGateway.ID
+	infra.Stats.TransitGatewayState.Status = *transitGateway.Status
+
+	if err = attachTag(gtag, options.InfraID, transitGateway.Crn, fmt.Sprintf("%s-%s", infra.ID, transitGatewayNameSuffix)); err != nil {


Suggested change

if err = attachTag(gtag, options.InfraID, transitGateway.Crn, fmt.Sprintf("%s-%s", infra.ID, transitGatewayNameSuffix)); err != nil {

if err := attachTag(gtag, options.InfraID, transitGateway.Crn, fmt.Sprintf("%s-%s", infra.ID, transitGatewayNameSuffix)); err != nil {

mkumatag · 2024-01-18T05:01:42Z

cmd/infra/powervs/create.go

+	if err != nil && err.Error() != transitGatewayNotFound(transitGatewayName).Error() {
+		return nil, fmt.Errorf("error validating existing transit gateway: %w", err)
+	}
+	if tg != nil && *tg.Status == "available" {


what if tg is not null(transit gateway exist) and state is not available?

mkumatag · 2024-01-18T05:08:11Z

cmd/infra/powervs/destroy.go

@@ -99,6 +103,9 @@ func NewDestroyCommand() *cobra.Command {
 	cmd.Flags().StringVar(&opts.CloudConnection, "cloud-connection", opts.CloudConnection, "IBM Cloud PowerVS Cloud Connection. Use this flag to reuse an existing Cloud Connection resource for cluster's infra")
 	cmd.Flags().StringVar(&opts.CloudInstanceID, "cloud-instance-id", opts.CloudInstanceID, "IBM PowerVS Cloud Instance ID. Use this flag to reuse an existing PowerVS Cloud Instance resource for cluster's infra")
 	cmd.Flags().BoolVar(&opts.Debug, "debug", opts.Debug, "Enabling this will result in debug logs will be printed")
+	cmd.Flags().BoolVar(&opts.UsePER, "use-power-edge-router", opts.UsePER, "Enabling this flag will denotes that Power Edge Router solution is used while creating the cluster")


Suggested change

cmd.Flags().BoolVar(&opts.UsePER, "use-power-edge-router", opts.UsePER, "Enabling this flag will denotes that Power Edge Router solution is used while creating the cluster")

cmd.Flags().BoolVar(&opts.PER, "power-edge-router", opts.PER, "Enabling this flag will denotes that Power Edge Router solution is used while creating the cluster")

mkumatag · 2024-01-18T05:10:31Z

cmd/infra/powervs/validate.go

+		return nil, transitGatewayNotFound(name)
+	}
+
+	if validateStatus {


you can have early return here in case if validateStatus is set as false

dharaneeshvrd · 2024-01-19T10:23:33Z

/retest-required

dharaneeshvrd · 2024-01-19T10:51:24Z

/retest-required

mkumatag

/lgtm

dharaneeshvrd · 2024-01-22T04:21:51Z

/retest-required

dharaneeshvrd · 2024-01-22T09:29:36Z

/retest-required

dharaneeshvrd · 2024-01-22T12:40:10Z

/retest-required

mkumatag · 2024-01-23T05:39:50Z

/lgtm

csrwng · 2024-02-01T15:04:07Z

cmd/infra/powervs/destroy.go

@@ -99,6 +103,9 @@ func NewDestroyCommand() *cobra.Command {
 	cmd.Flags().StringVar(&opts.CloudConnection, "cloud-connection", opts.CloudConnection, "IBM Cloud PowerVS Cloud Connection. Use this flag to reuse an existing Cloud Connection resource for cluster's infra")
 	cmd.Flags().StringVar(&opts.CloudInstanceID, "cloud-instance-id", opts.CloudInstanceID, "IBM PowerVS Cloud Instance ID. Use this flag to reuse an existing PowerVS Cloud Instance resource for cluster's infra")
 	cmd.Flags().BoolVar(&opts.Debug, "debug", opts.Debug, "Enabling this will result in debug logs will be printed")
+	cmd.Flags().BoolVar(&opts.PER, "power-edge-router", opts.PER, "Enabling this flag will denotes that Power Edge Router solution is used while creating the cluster")


The description doesn't seem to make sense for the destroy command. Something like, "Enabling this flag ensures that the Power Edge router that was used to create the cluster is cleaned up."

csrwng · 2024-02-01T15:04:31Z

cmd/infra/powervs/destroy.go

@@ -99,6 +103,9 @@ func NewDestroyCommand() *cobra.Command {
 	cmd.Flags().StringVar(&opts.CloudConnection, "cloud-connection", opts.CloudConnection, "IBM Cloud PowerVS Cloud Connection. Use this flag to reuse an existing Cloud Connection resource for cluster's infra")
 	cmd.Flags().StringVar(&opts.CloudInstanceID, "cloud-instance-id", opts.CloudInstanceID, "IBM PowerVS Cloud Instance ID. Use this flag to reuse an existing PowerVS Cloud Instance resource for cluster's infra")
 	cmd.Flags().BoolVar(&opts.Debug, "debug", opts.Debug, "Enabling this will result in debug logs will be printed")
+	cmd.Flags().BoolVar(&opts.PER, "power-edge-router", opts.PER, "Enabling this flag will denotes that Power Edge Router solution is used while creating the cluster")
+	cmd.Flags().StringVar(&opts.TransitGatewayLocation, "transit-gateway-location", opts.TransitGatewayLocation, "IBM Cloud Transit Gateway location")
+	cmd.Flags().StringVar(&opts.TransitGateway, "transit-gateway", opts.TransitGateway, "IBM Cloud Transit Gateway. Use this flag to reuse an existing Transit Gateway resource for cluster's infra")


Same as above, the wording should be different for the destroy command.

csrwng · 2024-02-01T15:05:29Z

cmd/infra/powervs/destroy.go

+		return err
+	}
+
+	if options.TransitGateway == "" {


nit: return early instead of enclosing a large block in the if

csrwng · 2024-02-01T15:06:30Z

Some comments, otherwise lgtm
/approve

openshift-ci · 2024-02-02T05:17:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, dharaneeshvrd, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [csrwng]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

… gateway More about PER: https://cloud.ibm.com/docs/power-iaas?topic=power-iaas-per

mkumatag · 2024-02-02T09:02:45Z

/lgtm

openshift-ci · 2024-02-02T09:58:13Z

@dharaneeshvrd: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 4, 2023

openshift-ci bot added the do-not-merge/needs-area label Dec 4, 2023

openshift-ci bot requested review from enxebre and isco-rodriguez December 4, 2023 14:03

openshift-ci bot added area/cli Indicates the PR includes changes for CLI area/documentation Indicates the PR includes changes for documentation area/testing Indicates the PR includes changes for e2e testing and removed do-not-merge/needs-area labels Dec 4, 2023

openshift-ci bot requested a review from mkumatag December 5, 2023 04:55

dharaneeshvrd force-pushed the add-transit-gw branch 2 times, most recently from 9fcb772 to 962131f Compare January 9, 2024 04:31

mkumatag suggested changes Jan 9, 2024

View reviewed changes

openshift-ci bot assigned mkumatag Jan 9, 2024

dharaneeshvrd force-pushed the add-transit-gw branch from 962131f to 78b8731 Compare January 11, 2024 14:35

dharaneeshvrd commented Jan 11, 2024

View reviewed changes

dharaneeshvrd force-pushed the add-transit-gw branch from 78b8731 to 054ac22 Compare January 18, 2024 04:40

mkumatag suggested changes Jan 18, 2024

View reviewed changes

dharaneeshvrd force-pushed the add-transit-gw branch 2 times, most recently from d490bad to f5bfb3b Compare January 19, 2024 09:45

mkumatag approved these changes Jan 19, 2024

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2024

dharaneeshvrd force-pushed the add-transit-gw branch from f5bfb3b to 925c812 Compare January 22, 2024 06:13

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2024

dharaneeshvrd force-pushed the add-transit-gw branch from 925c812 to e558df6 Compare February 1, 2024 14:26

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2024

csrwng reviewed Feb 1, 2024

View reviewed changes

dharaneeshvrd force-pushed the add-transit-gw branch from e558df6 to f1af507 Compare February 2, 2024 05:17

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2024

dharaneeshvrd added 2 commits February 2, 2024 11:36

MULTIARCH-3882: Support PER solution for powervs platform via transit…

f5bccb2

… gateway More about PER: https://cloud.ibm.com/docs/power-iaas?topic=power-iaas-per

MULTIARCH-3882: go vendor update

9f567c2

dharaneeshvrd force-pushed the add-transit-gw branch from f1af507 to 9f567c2 Compare February 2, 2024 06:27

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2024

openshift-merge-bot bot merged commit 198899a into openshift:main Feb 2, 2024
12 checks passed

	cmd.Flags().BoolVar(&opts.PowerVSPlatform.UsePER, "use-power-edge-router", opts.PowerVSPlatform.UsePER, "Enabling this flag will denotes that Power Edge Router solution is used while creating the cluster")
	cmd.Flags().BoolVar(&opts.PowerVSPlatform.PER, "power-edge-router", opts.PowerVSPlatform.PER, "Enabling this flag will denotes that Power Edge Router solution is used while creating the cluster")

	cmd.Flags().BoolVar(&opts.UsePER, "use-power-edge-router", opts.UsePER, "Enabling this flag will utilize Power Edge Router solution via transit gateway instead of cloud connection to create a connection between PowerVS and VPC")
	cmd.Flags().BoolVar(&opts.PER, "power-edge-router", opts.PER, "Enabling this flag will utilize Power Edge Router solution via transit gateway instead of cloud connection to create a connection between PowerVS and VPC")

	if err = infra.setupTransitGateway(ctx, options, gtag); err != nil {
	if err := infra.setupTransitGateway(ctx, options, gtag); err != nil {

	if err = infra.isCloudConnectionReady(ctx, options, session); err != nil {
	if err := infra.isCloudConnectionReady(ctx, options, session); err != nil {

	if err = attachTag(gtag, options.InfraID, transitGateway.Crn, fmt.Sprintf("%s-%s", infra.ID, transitGatewayNameSuffix)); err != nil {
	if err := attachTag(gtag, options.InfraID, transitGateway.Crn, fmt.Sprintf("%s-%s", infra.ID, transitGatewayNameSuffix)); err != nil {

MULTIARCH-3882: Support PER solution for powervs platform via transit gateway #3277

MULTIARCH-3882: Support PER solution for powervs platform via transit gateway #3277

Conversation

dharaneeshvrd commented Dec 4, 2023

openshift-ci-robot commented Dec 4, 2023 • edited by openshift-ci bot

netlify bot commented Dec 4, 2023 • edited

✅ Deploy Preview for hypershift-docs ready!

dharaneeshvrd commented Dec 5, 2023

dharaneeshvrd commented Dec 5, 2023

csrwng commented Dec 11, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dharaneeshvrd Jan 11, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dharaneeshvrd left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dharaneeshvrd Jan 11, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dharaneeshvrd commented Jan 19, 2024

dharaneeshvrd commented Jan 19, 2024

mkumatag left a comment

Choose a reason for hiding this comment

dharaneeshvrd commented Jan 22, 2024

dharaneeshvrd commented Jan 22, 2024

dharaneeshvrd commented Jan 22, 2024

mkumatag commented Jan 23, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

csrwng commented Feb 1, 2024

openshift-ci bot commented Feb 2, 2024

mkumatag commented Feb 2, 2024

openshift-ci bot commented Feb 2, 2024

openshift-ci-robot commented Dec 4, 2023 •

edited by openshift-ci bot

netlify bot commented Dec 4, 2023 •

edited

dharaneeshvrd Jan 11, 2024 •

edited

dharaneeshvrd Jan 11, 2024 •

edited