Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOSTEDCP-1314: Ensure all e2e HCs use NLB for ingress controller #3293

Merged
merged 1 commit into from Jan 16, 2024
Merged

HOSTEDCP-1314: Ensure all e2e HCs use NLB for ingress controller #3293

merged 1 commit into from Jan 16, 2024

Conversation

Patryk-Stefanski
Copy link
Contributor

What this PR does / why we need it: Adds check to validate that e2e HCs use NLB for ingress controller

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes # HOSTEDCP-1314

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 7, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 7, 2023 •
edited by openshift-ci bot

@Patryk-Stefanski: This pull request references HOSTEDCP-1314 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

What this PR does / why we need it: Adds check to validate that e2e HCs use NLB for ingress controller

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes # HOSTEDCP-1314

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 7, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 7, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@Patryk-Stefanski
Copy link
Contributor Author

/test all

@openshift-ci openshift-ci bot added area/testing Indicates the PR includes changes for e2e testing and removed do-not-merge/needs-area labels Dec 7, 2023
@netlify Netlify
Copy link

netlify bot commented Dec 7, 2023 •
edited

✅ Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit d96c682
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/659bb977b0e461000869decb
😎 Deploy Preview https://deploy-preview-3293--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Patryk-Stefanski
Copy link
Contributor Author

/retest-required

@openshift-ci openshift-ci bot added the area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release label Dec 7, 2023
@Patryk-Stefanski
Copy link
Contributor Author

/retest

@Patryk-Stefanski
Copy link
Contributor Author

/test all

@Patryk-Stefanski
Copy link
Contributor Author

/retest-required

@enxebre
Copy link
Member

enxebre commented Dec 11, 2023

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, Patryk-Stefanski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2023
enxebre
enxebre reviewed Dec 11, 2023
View reviewed changes
control-plane-operator/hostedclusterconfigoperator/controllers/resources/ingress/reconcile.go
@@ -43,7 +43,7 @@ func ReconcileDefaultIngressController(ingressController *operatorv1.IngressCont
case hyperv1.AWSPlatform:
if useNLB {
ingressController.Spec.EndpointPublishingStrategy.LoadBalancer = &operatorv1.LoadBalancerStrategy{
Scope: operatorv1.ExternalLoadBalancer,
Scope: nlbScope,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it actually makes sense to do this so we internal by default when aws topology is private cc @csrwng any concerns?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concerns from me

@Patryk-Stefanski Patryk-Stefanski marked this pull request as ready for review December 11, 2023 12:03
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 11, 2023
@Patryk-Stefanski Patryk-Stefanski force-pushed the HOSTEDCP-1314 branch 2 times, most recently from 339379b to f229d99 Compare December 13, 2023 16:25
@Patryk-Stefanski
Copy link
Contributor Author

/retest-required

@bryan-cox
Copy link
Member

/retest

@Patryk-Stefanski
Copy link
Contributor Author

/retest-required

1 similar comment
@Patryk-Stefanski
Copy link
Contributor Author

/retest-required

@Patryk-Stefanski Patryk-Stefanski force-pushed the HOSTEDCP-1314 branch 2 times, most recently from c739dcf to d96c682 Compare January 8, 2024 08:59
@Patryk-Stefanski
Copy link
Contributor Author

/test e2e-aws

@Patryk-Stefanski
Copy link
Contributor Author

/test e2e-aws

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 16, 2024

@Patryk-Stefanski: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@muraee
Copy link
Contributor

muraee commented Jan 16, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 4951322 into openshift:main Jan 16, 2024
12 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-hypershift-container-v4.16.0-202401161431.p0.g4951322.assembly.stream for distgit hypershift.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enxebre enxebre enxebre left review comments

@csrwng csrwng csrwng left review comments

@hasueki hasueki Awaiting requested review from hasueki

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@muraee muraee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/testing Indicates the PR includes changes for e2e testing jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Patryk-Stefanski @openshift-ci-robot @enxebre @bryan-cox @muraee @openshift-bot @csrwng