Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TRT-1406: Revert #3283 "HOSTEDCP-1273: Added support for OLM Disable default sources on HC creation" #3306

Merged
merged 1 commit into from Dec 12, 2023
Merged

TRT-1406: Revert #3283 "HOSTEDCP-1273: Added support for OLM Disable default sources on HC creation" #3306

merged 1 commit into from Dec 12, 2023

Conversation

stbenjam
Copy link
Member

@stbenjam stbenjam commented Dec 11, 2023 •
edited by openshift-ci bot

Reverts #3283 ; tracked by TRT-1406

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

[sig-operator] an end user can use OLM can subscribe to the operator [apigroup:config.openshift.io] is failing on hypershift conformance jobs, it looks like this is the cause

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

Verify this test passes on conformance

CC: @jparrill

PR created by Revertomatic™️

@stbenjam
Revert "Merge pull request openshift#3283 from jparrill/feat/HOSTEDCP…
77cb849 
…-1273"

This reverts commit 6315b72, reversing
changes made to 38cf5f2.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 11, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 11, 2023 •
edited by openshift-ci bot

@stbenjam: This pull request references TRT-1406 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Reverts #3283 ; tracked by TRT-1406

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

[sig-operator] an end user can use OLM can subscribe to the operator [apigroup:config.openshift.io] is failing on hypershift conformance jobs, it looks like this is the cause

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

Verify this test passes on conformance

CC: @jparrill

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam
Copy link
Member Author

/payload-job periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn-conformance

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 11, 2023

@stbenjam: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2ea365c0-9875-11ee-8f87-0cfa562a0f1c-0

@netlify Netlify
Copy link

netlify bot commented Dec 11, 2023

✅ Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit 77cb849
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/65778de758f38a000878e7e6
😎 Deploy Preview https://deploy-preview-3306--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@openshift-ci openshift-ci bot added area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release and removed do-not-merge/needs-area labels Dec 11, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 11, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stbenjam
Once this PR has been reviewed and has the lgtm label, please assign enxebre for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added area/documentation Indicates the PR includes changes for documentation area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release labels Dec 11, 2023
@stbenjam
Copy link
Member Author

/hold

Pending confirmation

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2023
@neisw
Copy link

neisw commented Dec 12, 2023

/lgtm

Next payload has the same failure and we can't verify this with payload command. Adding lgtm in case you want to proceed.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2023
@stbenjam
Copy link
Member Author

/label approved
/skip

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2023
@stbenjam
Copy link
Member Author

/hold cancel

We don't have any other ideas, and we can't verify this PR with /payload. We'll immediately unrevert this if we got it wrong.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2023
@sjenning
Copy link
Contributor

/test e2e-aws-conformance

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 12, 2023

@sjenning: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-aws
  • /test e2e-kubevirt-aws-ovn
  • /test images
  • /test unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test e2e-aws-4-12
  • /test e2e-aws-4-13
  • /test e2e-aws-metrics
  • /test e2e-conformance
  • /test e2e-ibmcloud-iks
  • /test e2e-ibmcloud-roks

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-hypershift-main-e2e-aws
  • pull-ci-openshift-hypershift-main-e2e-ibmcloud-iks
  • pull-ci-openshift-hypershift-main-e2e-ibmcloud-roks
  • pull-ci-openshift-hypershift-main-e2e-kubevirt-aws-ovn
  • pull-ci-openshift-hypershift-main-images
  • pull-ci-openshift-hypershift-main-unit
  • pull-ci-openshift-hypershift-main-verify

In response to this:

/test e2e-aws-conformance

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sjenning
Copy link
Contributor

/test e2e-conformance

@jparrill
Copy link
Contributor

created a cherry-pick for release 4.15 to trigger the conformance tests #3310

@openshift-merge-bot openshift-merge-bot bot merged commit a5c103b into openshift:main Dec 12, 2023
13 of 14 checks passed
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 12, 2023

@stbenjam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud-iks 77cb849 link false /test e2e-ibmcloud-iks
ci/prow/e2e-ibmcloud-roks 77cb849 link false /test e2e-ibmcloud-roks

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

This was referenced Dec 13, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enxebre enxebre Awaiting requested review from enxebre

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@neisw neisw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/documentation Indicates the PR includes changes for documentation area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@stbenjam @openshift-ci-robot @neisw @sjenning @jparrill