Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOSTEDCP-1372: Bumps k8s to v0.29 #3360

Merged
merged 4 commits into from Jan 8, 2024
Merged

HOSTEDCP-1372: Bumps k8s to v0.29 #3360

merged 4 commits into from Jan 8, 2024

Conversation

bryan-cox
Copy link
Member

@bryan-cox bryan-cox commented Jan 2, 2024 •
edited

What this PR does / why we need it:
Bumps k8s to v0.29

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes HOSTEDCP-1372

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 2, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 2, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added do-not-merge/needs-area area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI labels Jan 2, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Jan 2, 2024
@bryan-cox
Copy link
Member Author

/hold
#3359 needs to merge first

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 2, 2024
@bryan-cox bryan-cox changed the title Bumps k8s to v0.29 HOSTEDCP-1372: Bumps k8s to v0.29 Jan 2, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 2, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 2, 2024 •
edited by openshift-ci bot

@bryan-cox: This pull request references HOSTEDCP-1372 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
Bumps k8s to v0.29

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 2, 2024 •
edited by openshift-ci bot

@bryan-cox: This pull request references HOSTEDCP-1372 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
Bumps k8s to v0.29

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes HOSTEDCP-1372

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bryan-cox
Copy link
Member Author

/test images
/test verify
/test unit
/test e2e-aws

@bryan-cox
Copy link
Member Author

/test images
/test verify

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 4, 2024
@bryan-cox
Bump k8s to v0.29.0
fe8a6ba 
Signed-off-by: Bryan Cox <brcox@redhat.com>
@bryan-cox
Fix Resources to use updated struct
03f305f 
Signed-off-by: Bryan Cox <brcox@redhat.com>
@bryan-cox
Pin cel-go to v0.17.7 due to issue with newest
0ce6dd6 
The apiserver/pkg/cel/library/cost.go failed with later versions of
cel-go. See
kubernetes/apiserver#97 for further
details.

Signed-off-by: Bryan Cox <brcox@redhat.com>
@bryan-cox
Remove k8s.io/kube-openapi replace
b62dc31 
Signed-off-by: Bryan Cox <brcox@redhat.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 4, 2024
@bryan-cox
Copy link
Member Author

/unhold
/test images
/test verify
/test unit
/test e2e-aws

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 4, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 4, 2024 •
edited by openshift-ci bot

@bryan-cox: This pull request references HOSTEDCP-1372 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
Bumps k8s to v0.29

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes HOSTEDCP-1372

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bryan-cox
Copy link
Member Author

/test e2e-aws

@bryan-cox
Copy link
Member Author

/retest

1 similar comment
@bryan-cox
Copy link
Member Author

/retest

@muraee
Copy link
Contributor

muraee commented Jan 5, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2024
@bryan-cox bryan-cox marked this pull request as ready for review January 5, 2024 15:02
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 5, 2024
@openshift-ci openshift-ci bot requested review from nirarg and sjenning January 5, 2024 15:02
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 34e73a2 and 2 for PR HEAD b62dc31 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 660b17b and 1 for PR HEAD b62dc31 in total

@bryan-cox
Copy link
Member Author

/retest

1 similar comment
@bryan-cox
Copy link
Member Author

/retest

@bryan-cox
Copy link
Member Author

/test e2e-aws

@bryan-cox
Copy link
Member Author

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 8, 2024

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 8bd5b20 into openshift:main Jan 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirarg nirarg Awaiting requested review from nirarg

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@muraee muraee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bryan-cox @openshift-ci-robot @muraee @openshift-merge-robot