Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.14] OCPBUGS-26526: Documented to disable UWM telemetry writer in disconnected envs #3389

Merged
merged 1 commit into from Feb 5, 2024

Conversation

jparrill
Copy link
Contributor

@jparrill jparrill commented Jan 9, 2024

This is a manual cherry-pick of #3380

/assign jparrill

@openshift-ci openshift-ci bot requested review from enxebre and hasueki January 9, 2024 10:06
@openshift-ci openshift-ci bot added area/documentation Indicates the PR includes changes for documentation area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release and removed do-not-merge/needs-area labels Jan 9, 2024
@jparrill
Copy link
Contributor Author

jparrill commented Jan 9, 2024

/jira cherrypick OCPBUGS-22399

@openshift-ci-robot
Copy link

@jparrill: Jira Issue OCPBUGS-22399 has been cloned as Jira Issue OCPBUGS-26527. Will retitle bug to link to clone.
/retitle OCPBUGS-26527: Documented to disable UWM telemetry writer in disconnected envs

In response to this:

/jira cherrypick OCPBUGS-22399

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title Documented to disable UWM telemetry writer in disconnected envs OCPBUGS-26527: Documented to disable UWM telemetry writer in disconnected envs Jan 9, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 9, 2024
@openshift-ci-robot
Copy link

@jparrill: This pull request references Jira Issue OCPBUGS-26527, which is invalid:

  • expected dependent Jira Issue OCPBUGS-22399 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead
  • expected dependent Jira Issue OCPBUGS-22399 to target a version in 4.15.0, but it targets "4.16.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a manual cherry-pick of #3380

/assign jparrill

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jparrill
Copy link
Contributor Author

jparrill commented Jan 9, 2024

/jira cherrypick OCPBUGS-26410

@openshift-ci-robot
Copy link

@jparrill: Detected clone of Jira Issue OCPBUGS-26410 with correct target version. Will retitle the PR to link to the clone.
/retitle OCPBUGS-26526: OCPBUGS-26527: Documented to disable UWM telemetry writer in disconnected envs

In response to this:

/jira cherrypick OCPBUGS-26410

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title OCPBUGS-26527: Documented to disable UWM telemetry writer in disconnected envs OCPBUGS-26526: OCPBUGS-26527: Documented to disable UWM telemetry writer in disconnected envs Jan 9, 2024
@openshift-ci-robot
Copy link

@jparrill: This pull request references Jira Issue OCPBUGS-26526, which is invalid:

  • expected dependent Jira Issue OCPBUGS-26410 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a manual cherry-pick of #3380

/assign jparrill

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jparrill jparrill changed the title OCPBUGS-26526: OCPBUGS-26527: Documented to disable UWM telemetry writer in disconnected envs [release-4.14] OCPBUGS-26526: Documented to disable UWM telemetry writer in disconnected envs Jan 9, 2024

**Symptoms:**

- The Hypershift operator appears to be running correctly in the `hypershift` namespace but even if you creates the Hosted Cluster nothing happens.
Copy link
Member

@enxebre enxebre Jan 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a known issue, what's causing this that can't be fixed instead of documented?
If telemetry not being reachable breaks HC reconciliation that's something we need to fix.

Then aside from that we recommend using --enable-uwm-telemetry-remote-write for disconnected.

Copy link
Contributor Author

@jparrill jparrill Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is not a good way to infer if a HC should be disconnected or not, maybe we can think in a flag to remark this or something similar but after a discussion with the team before christmas shutdown, we decide that the best option for now it's just to document it.

Said that, to avoid break the reconciliation, I've included in the jira issue another PR #3388. It checks if a ConfigMap exists (needed by the TelemeterClient) if the CM does not exists, the controller will not reconcile.

@jparrill
Copy link
Contributor Author

/test e2e-kubevirt-aws-ovn

1 similar comment
@orenc1
Copy link
Contributor

orenc1 commented Jan 11, 2024

/test e2e-kubevirt-aws-ovn

@jparrill
Copy link
Contributor Author

/retest

@jparrill
Copy link
Contributor Author

/test "Red Hat Trusted App Test / mce-24-txk4k / tektok-runner-enterprise-contract-mce-2.4"

Copy link
Contributor

openshift-ci bot commented Jan 11, 2024

@jparrill: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-aws
  • /test e2e-kubevirt-aws-ovn
  • /test images
  • /test unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test e2e-aws-4-12
  • /test e2e-aws-4-13
  • /test e2e-aws-metrics
  • /test e2e-conformance
  • /test e2e-ibmcloud-iks
  • /test e2e-ibmcloud-roks
  • /test mce-images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-hypershift-release-4.14-e2e-aws
  • pull-ci-openshift-hypershift-release-4.14-e2e-ibmcloud-iks
  • pull-ci-openshift-hypershift-release-4.14-e2e-ibmcloud-roks
  • pull-ci-openshift-hypershift-release-4.14-e2e-kubevirt-aws-ovn
  • pull-ci-openshift-hypershift-release-4.14-images
  • pull-ci-openshift-hypershift-release-4.14-unit
  • pull-ci-openshift-hypershift-release-4.14-verify

In response to this:

/test "Red Hat Trusted App Test / mce-24-txk4k / tektok-runner-enterprise-contract-mce-2.4"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jparrill
Copy link
Contributor Author

/retest

@sjenning
Copy link
Contributor

/override "Red Hat Trusted App Test / mce-24-txk4k / tektok-runner-enterprise-contract-mce-2.4"
/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2024
Copy link
Contributor

openshift-ci bot commented Jan 11, 2024

@sjenning: Overrode contexts on behalf of sjenning: Red Hat Trusted App Test / mce-24-txk4k / tektok-runner-enterprise-contract-mce-2.4

In response to this:

/override "Red Hat Trusted App Test / mce-24-txk4k / tektok-runner-enterprise-contract-mce-2.4"
/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Jan 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2024
@jparrill
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@jparrill: This pull request references Jira Issue OCPBUGS-26526, which is invalid:

  • expected dependent Jira Issue OCPBUGS-26410 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

…cted envs

Signed-off-by: Juan Manuel Parrilla Madrid <jparrill@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2024
@jparrill
Copy link
Contributor Author

/retest-required

@jparrill
Copy link
Contributor Author

/test e2e-aws

@LiangquanLi930
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2024
@LiangquanLi930
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 5, 2024
@openshift-ci-robot
Copy link

@LiangquanLi930: This pull request references Jira Issue OCPBUGS-26526, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-26410 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-26410 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

Requesting review from QA contact:
/cc @LiangquanLi930

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Feb 5, 2024

@jparrill: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit ad3bd20 into openshift:release-4.14 Feb 5, 2024
10 checks passed
@openshift-ci-robot
Copy link

@jparrill: Jira Issue OCPBUGS-26526: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-26526 has been moved to the MODIFIED state.

In response to this:

This is a manual cherry-pick of #3380

/assign jparrill

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.14.0-0.nightly-2024-02-06-000359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Indicates the PR includes changes for documentation area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants