Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: [KubeVirt] Fix external infra permissions documentation #3391

Merged
merged 1 commit into from Jan 9, 2024

Conversation

orenc1
Copy link
Contributor

@orenc1 orenc1 commented Jan 9, 2024

Fixing #3364 as validated at openshift/release#47248

https://github.com/openshift/release/blob/dfe99ad69ace3195ea73fcd30265e8d9cc2b9f81/ci-operator/step-registry/hypershift/kubevirt/install/create-external-infra-kubeconfig/hypershift-kubevirt-install-create-external-infra-kubeconfig-commands.sh#L44-L81

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

fixing openshift#3364 as validated at openshift/release#47248

Signed-off-by: Oren Cohen <ocohen@redhat.com>
@openshift-ci openshift-ci bot requested review from csrwng and sjenning January 9, 2024 13:35
@openshift-ci openshift-ci bot added area/documentation Indicates the PR includes changes for documentation and removed do-not-merge/needs-area labels Jan 9, 2024
Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit 357df4e
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/659d4b5389a97f0008146afa
😎 Deploy Preview https://deploy-preview-3391--hypershift-docs.netlify.app/how-to/kubevirt/external-infrastructure
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

openshift-ci bot commented Jan 9, 2024

@orenc1: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@davidvossel davidvossel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2024
Copy link
Contributor

openshift-ci bot commented Jan 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel, orenc1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2024
@orenc1 orenc1 changed the title [KubeVirt] Fix external infra permissions documentation NO-JIRA: [KubeVirt] Fix external infra permissions documentation Jan 9, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 9, 2024
@openshift-ci-robot
Copy link

@orenc1: This pull request explicitly references no jira issue.

In response to this:

Fixing #3364 as validated at openshift/release#47248

https://github.com/openshift/release/blob/dfe99ad69ace3195ea73fcd30265e8d9cc2b9f81/ci-operator/step-registry/hypershift/kubevirt/install/create-external-infra-kubeconfig/hypershift-kubevirt-install-create-external-infra-kubeconfig-commands.sh#L44-L81

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 6a632af into openshift:main Jan 9, 2024
8 checks passed
@orenc1 orenc1 deleted the kv_ext_infra_doc_fix branch January 9, 2024 15:08
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-hypershift-container-v4.16.0-202401091911.p0.g6a632af.assembly.stream for distgit hypershift.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Indicates the PR includes changes for documentation jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants