Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Update Dockerfiles to use publicly available RHEL9 images #3426

Merged
merged 1 commit into from Jan 23, 2024

Conversation

csrwng
Copy link
Contributor

@csrwng csrwng commented Jan 15, 2024

What this PR does / why we need it:
This is needed for compatibility with RHEL9-based images in the release payload. The change will not impact CI or ART images, since they use their own replacements

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Copy link
Contributor

openshift-ci bot commented Jan 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2024
This is needed for compatibility with RHEL9-based images in the release payload. The change will not impact CI or ART images, since they use their own replacements
@csrwng
Copy link
Contributor Author

csrwng commented Jan 16, 2024

/hold
A pr to the release repo needs to merge first so this change doesn't impact images used there

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2024
@bryan-cox
Copy link
Member

/area ci-tooling

@openshift-ci openshift-ci bot added the area/ci-tooling Indicates the PR includes changes for CI or tooling label Jan 22, 2024
Copy link
Member

@bryan-cox bryan-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to modify Containerfile.operator as well?

@bryan-cox
Copy link
Member

/retest

Copy link
Member

@bryan-cox bryan-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bryan-cox
Copy link
Member

/retitle NO-JIRA: Update Dockerfiles to use publicly available RHEL9 images

@csrwng
Copy link
Contributor Author

csrwng commented Jan 22, 2024

/hold cancel

@sjenning sjenning added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 22, 2024
@csrwng csrwng changed the title Update Dockerfiles to use publicly available RHEL9 images NO-JIRA: Update Dockerfiles to use publicly available RHEL9 images Jan 22, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 22, 2024
@openshift-ci-robot
Copy link

@csrwng: This pull request explicitly references no jira issue.

In response to this:

What this PR does / why we need it:
This is needed for compatibility with RHEL9-based images in the release payload. The change will not impact CI or ART images, since they use their own replacements

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ef43500 and 2 for PR HEAD d5d2935 in total

Copy link
Contributor

openshift-ci bot commented Jan 23, 2024

@csrwng: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit c32704f into openshift:main Jan 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci-tooling Indicates the PR includes changes for CI or tooling jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants