Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-JIRA: Update RHTAP references (release-4.14) #3447

Merged
merged 3 commits into from Jan 26, 2024
Merged

NO-JIRA: Update RHTAP references (release-4.14) #3447

merged 3 commits into from Jan 26, 2024

Conversation

bryan-cox
Copy link
Member

What this PR does / why we need it:
Includes RHTAP updates and fixes things needed from the migration - https://github.com/redhat-appstudio/build-definitions/blob/main/task/init/0.2/MIGRATION.md

Which issue(s) this PR fixes:
N/A

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

red-hat-trusted-app-pipeline and others added 2 commits January 22, 2024 10:05
@bryan-cox
Update RHTAP references
fd4c415
@bryan-cox
Remove tasks not needed since migration to v0.2
ae68939 
Removes skip-optional, pipelinerun-name and  pipelinerun-uid parameters
from the params section per
https://github.com/redhat-appstudio/build-definitions/blob/main/task
/init/0.2/MIGRATION.md.

Signed-off-by: Bryan Cox <brcox@redhat.com>
@bryan-cox bryan-cox changed the title Update RHTAP references (release-4.14) NO-JIRA: Update RHTAP references (release-4.14) Jan 22, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 22, 2024
@openshift-ci-robot
Copy link

@bryan-cox: This pull request explicitly references no jira issue.

In response to this:

What this PR does / why we need it:
Includes RHTAP updates and fixes things needed from the migration - https://github.com/redhat-appstudio/build-definitions/blob/main/task/init/0.2/MIGRATION.md

Which issue(s) this PR fixes:
N/A

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bryan-cox
Copy link
Member Author

/retest

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-area labels Jan 22, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 22, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@bryan-cox
Copy link
Member Author

/area ci-tooling

@openshift-ci openshift-ci bot added area/ci-tooling Indicates the PR includes changes for CI or tooling and removed do-not-merge/needs-area labels Jan 22, 2024
@bryan-cox
Copy link
Member Author

/retest

@bryan-cox
Remove DOCKER_AUTH
49f3e49 
Signed-off-by: Bryan Cox <brcox@redhat.com>
@bryan-cox
Copy link
Member Author

/test images
/test verify

@bryan-cox
Copy link
Member Author

/retest

1 similar comment
@bryan-cox
Copy link
Member Author

/retest

@bryan-cox bryan-cox marked this pull request as ready for review January 26, 2024 18:36
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 26, 2024
@csrwng
Copy link
Contributor

csrwng commented Jan 26, 2024

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, csrwng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 6836d19 into openshift:release-4.14 Jan 26, 2024
5 of 7 checks passed
@bryan-cox bryan-cox deleted the fix-rhtap-pr-4.14 branch January 26, 2024 19:04
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-hypershift-container-v4.14.0-202401261353.p0.g6836d19.assembly.stream for distgit hypershift.
All builds following this will include this PR.

@bryan-cox bryan-cox mentioned this pull request Jan 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasueki hasueki Awaiting requested review from hasueki

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

Assignees

@csrwng csrwng

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci-tooling Indicates the PR includes changes for CI or tooling jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bryan-cox @openshift-ci-robot @csrwng @openshift-bot