Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: kubevirt, e2e, Add additional network test #3449

Merged

Conversation

qinqon
Copy link
Contributor

@qinqon qinqon commented Jan 22, 2024

What this PR does / why we need it:
Add a e2e at kubevirt provider with a additional network nodepool that will check if that additional network is configured at the VMI.

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci openshift-ci bot added area/testing Indicates the PR includes changes for e2e testing and removed do-not-merge/needs-area labels Jan 22, 2024
@qinqon qinqon force-pushed the kubevirt-add-additional-net-e2e branch from 8e1aaab to e5f5030 Compare January 24, 2024 12:48
Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit 7fced84
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/65b220a70157420008f41b58
😎 Deploy Preview https://deploy-preview-3449--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@qinqon qinqon force-pushed the kubevirt-add-additional-net-e2e branch 3 times, most recently from 1465d3c to 7fced84 Compare January 25, 2024 08:49
@qinqon
Copy link
Contributor Author

qinqon commented Jan 26, 2024

/retest

@qinqon qinqon force-pushed the kubevirt-add-additional-net-e2e branch 4 times, most recently from 87a4aea to 94521a1 Compare January 29, 2024 10:48
@qinqon
Copy link
Contributor Author

qinqon commented Jan 29, 2024

/retest

@qinqon qinqon force-pushed the kubevirt-add-additional-net-e2e branch 6 times, most recently from 01671b8 to 632527c Compare January 31, 2024 10:29
Add a e2e at kubevirt provider with a additional network nodepool that
will check if that additional network is configured at the VMI.

Signed-off-by: Enrique Llorente <ellorent@redhat.com>
@qinqon qinqon force-pushed the kubevirt-add-additional-net-e2e branch from 632527c to 596861f Compare January 31, 2024 11:44
Copy link
Contributor

@davidvossel davidvossel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2024
Copy link
Contributor

openshift-ci bot commented Jan 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel, qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2024
@qinqon qinqon changed the title kubevirt, e2e: Add additional network test NO JIRA: kubevirt, e2e, Add additional network test Jan 31, 2024
@qinqon qinqon changed the title NO JIRA: kubevirt, e2e, Add additional network test NO-JIRA: kubevirt, e2e, Add additional network test Jan 31, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 31, 2024
@openshift-ci-robot
Copy link

@qinqon: This pull request explicitly references no jira issue.

In response to this:

What this PR does / why we need it:
Add a e2e at kubevirt provider with a additional network nodepool that will check if that additional network is configured at the VMI.

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 056d92e and 2 for PR HEAD 596861f in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1cdcd77 and 1 for PR HEAD 596861f in total

@qinqon
Copy link
Contributor Author

qinqon commented Feb 1, 2024

/cherry-pick release-4.15

@openshift-cherrypick-robot

@qinqon: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 36eed53 and 0 for PR HEAD 596861f in total

Copy link
Contributor

openshift-ci bot commented Feb 1, 2024

@qinqon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit aedf3e6 into openshift:main Feb 1, 2024
12 checks passed
@openshift-cherrypick-robot

@qinqon: #3449 failed to apply on top of branch "release-4.15":

Applying: kubevirt, e2e: Add additional network test
.git/rebase-apply/patch:131: trailing whitespace.
  name: %[2]s 
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	test/e2e/nodepool_test.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/nodepool_test.go
CONFLICT (content): Merge conflict in test/e2e/nodepool_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 kubevirt, e2e: Add additional network test
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-hypershift-container-v4.16.0-202402011541.p0.gaedf3e6.assembly.stream for distgit hypershift.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Indicates the PR includes changes for e2e testing jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants