Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-26940: Include OperatorHubSpec sync with HC when Config is empty #3454

Merged
merged 1 commit into from Jan 26, 2024
Merged

OCPBUGS-26940: Include OperatorHubSpec sync with HC when Config is empty #3454

merged 1 commit into from Jan 26, 2024

Conversation

jparrill
Copy link
Contributor

@jparrill jparrill commented Jan 23, 2024 •
edited

This PR Contains:

  • Fixed bug
  • Added ReconcileOLM unitTests

Signed-off-by: Juan Manuel Parrilla Madrid jparrill@redhat.com

Which issue(s) this PR fixes :
Fixes #OCPBUGS-26940

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 23, 2024
@openshift-ci-robot
Copy link

@jparrill: This pull request references Jira Issue OCPBUGS-26940, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Signed-off-by: Juan Manuel Parrilla Madrid jparrill@redhat.com

Which issue(s) this PR fixes :
Fixes #OCPBUGS-26940

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release label Jan 23, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Jan 23, 2024
@jparrill
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 23, 2024
@openshift-ci-robot
Copy link

@jparrill: This pull request references Jira Issue OCPBUGS-26940, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@jparrill: This pull request references Jira Issue OCPBUGS-26940, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

In response to this:

  • Fixed bug
  • Added ReconcileOLM unitTests

Signed-off-by: Juan Manuel Parrilla Madrid jparrill@redhat.com

Which issue(s) this PR fixes :
Fixes #OCPBUGS-26940

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jparrill
OCPBUGS-26940: Include OperatorHubSpec sync with HC when Config is empty
b4209f3 
Signed-off-by: Juan Manuel Parrilla Madrid <jparrill@redhat.com>
@jparrill
Copy link
Contributor Author

/retest

2 similar comments
@bryan-cox
Copy link
Member

/retest

@jparrill
Copy link
Contributor Author

/retest

@jparrill
Copy link
Contributor Author

/test e2e-kubevirt-aws-ovn

@muraee
Copy link
Contributor

muraee commented Jan 26, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 26, 2024

@jparrill: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 9e6255e into openshift:main Jan 26, 2024
12 checks passed
@openshift-ci-robot
Copy link

@jparrill: Jira Issue OCPBUGS-26940: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-26940 has been moved to the MODIFIED state.

In response to this:

This PR Contains:

  • Fixed bug
  • Added ReconcileOLM unitTests

Signed-off-by: Juan Manuel Parrilla Madrid jparrill@redhat.com

Which issue(s) this PR fixes :
Fixes #OCPBUGS-26940

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jparrill
Copy link
Contributor Author

/cherry-pick release-4.15

@openshift-cherrypick-robot
Copy link

@jparrill: new pull request created: #3480

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 29, 2024
Merged
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-01-31-073538

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muraee muraee muraee left review comments

@bryan-cox bryan-cox bryan-cox left review comments

@csrwng csrwng Awaiting requested review from csrwng

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

Assignees

@muraee muraee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jparrill @openshift-ci-robot @bryan-cox @muraee @openshift-cherrypick-robot @openshift-merge-robot