Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-28576: re-revert api stuff #3463

Merged
merged 2 commits into from Jan 26, 2024
Merged

OCPBUGS-28576: re-revert api stuff #3463

merged 2 commits into from Jan 26, 2024

Conversation

stevekuznetsov
Copy link
Contributor

Revert "Merge pull request #3460 from stbenjam/revert-3448-1706107197301"

This reverts commit d7b8d75, reversing
changes made to 6c84753.

api: re-add the v1beta1 CSRA

Signed-off-by: Steve Kuznetsov skuznets@redhat.com

@stevekuznetsov
Revert "Merge pull request openshift#3460 from stbenjam/revert-3448-1…
1e1fef7 
…706107197301"

This reverts commit d7b8d75, reversing
changes made to 6c84753.
@stevekuznetsov
api: re-add the v1beta1 CSRA
63537e8 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov stevekuznetsov changed the title re-revert api stuff HOSTEDCP-1344: re-revert api stuff Jan 24, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 24, 2024 •
edited by openshift-ci bot

@stevekuznetsov: This pull request references HOSTEDCP-1344 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Revert "Merge pull request #3460 from stbenjam/revert-3448-1706107197301"

This reverts commit d7b8d75, reversing
changes made to 6c84753.

api: re-add the v1beta1 CSRA

Signed-off-by: Steve Kuznetsov skuznets@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 24, 2024
@openshift-ci openshift-ci bot added area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/control-plane-pki-operator Indicates the PR includes changes for the control plane PKI operator - in an OCP release area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release area/testing Indicates the PR includes changes for e2e testing and removed do-not-merge/needs-area labels Jan 24, 2024
@stevekuznetsov
Copy link
Contributor Author

/retest

@sjenning
Copy link
Contributor

/approve
/lgtm
/test "Red Hat Trusted App Pipeline / hypershift-operator-main-on-pull-request"

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 26, 2024

@sjenning: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-aws
  • /test e2e-kubevirt-aws-ovn
  • /test images
  • /test unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test e2e-aws-4-12
  • /test e2e-aws-4-13
  • /test e2e-aws-metrics
  • /test e2e-conformance
  • /test e2e-ibmcloud-iks
  • /test e2e-ibmcloud-roks

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-hypershift-main-e2e-aws
  • pull-ci-openshift-hypershift-main-e2e-ibmcloud-iks
  • pull-ci-openshift-hypershift-main-e2e-ibmcloud-roks
  • pull-ci-openshift-hypershift-main-e2e-kubevirt-aws-ovn
  • pull-ci-openshift-hypershift-main-images
  • pull-ci-openshift-hypershift-main-unit
  • pull-ci-openshift-hypershift-main-verify

In response to this:

/approve
/lgtm
/test "Red Hat Trusted App Pipeline / hypershift-operator-main-on-pull-request"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sjenning, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2024
@sjenning
Copy link
Contributor

/retest

1 similar comment
@sjenning
Copy link
Contributor

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 26, 2024

@stevekuznetsov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud-iks 63537e8 link false /test e2e-ibmcloud-iks
ci/prow/e2e-ibmcloud-roks 63537e8 link false /test e2e-ibmcloud-roks

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 16a90de into openshift:main Jan 26, 2024
12 of 14 checks passed
@stevekuznetsov stevekuznetsov changed the title HOSTEDCP-1344: re-revert api stuff OCPBUGS-28576: re-revert api stuff Jan 29, 2024
@openshift-ci-robot
Copy link

@stevekuznetsov: Jira Issue OCPBUGS-28576: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-28576 has not been moved to the MODIFIED state.

In response to this:

Revert "Merge pull request #3460 from stbenjam/revert-3448-1706107197301"

This reverts commit d7b8d75, reversing
changes made to 6c84753.

api: re-add the v1beta1 CSRA

Signed-off-by: Steve Kuznetsov skuznets@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stevekuznetsov
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@stevekuznetsov: Jira Issue OCPBUGS-28576: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-28576 has not been moved to the MODIFIED state.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stevekuznetsov
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@stevekuznetsov: Jira Issue OCPBUGS-28576: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-28576 has been moved to the MODIFIED state.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enxebre enxebre Awaiting requested review from enxebre

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

Assignees

@sjenning sjenning

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/control-plane-pki-operator Indicates the PR includes changes for the control plane PKI operator - in an OCP release area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release area/testing Indicates the PR includes changes for e2e testing jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stevekuznetsov @openshift-ci-robot @sjenning