NO-JIRA: KubeVirt Platform Documentation for Additional Network, CPU Performance, and VM NodeSelector #3464
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@davidvossel: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
area/documentation
✅ Deploy Preview for hypershift-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidvossel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
approved
|
/cc |
| ## Attaching Additional Networks to KubeVirt VMs | ||
|
|
||
| Attaching additional networks to a KubeVirt NodePool is accomplished through | ||
| the usage of multus and [NetworkAttachmentDefinitions](https://docs.openshift.com/container-platform/4.14/rest_api/network_apis/networkattachmentdefinition-k8s-cni-cncf-io-v1.html). Below is an example |
There was a problem hiding this comment.
We can add the kubevirt blog practical examples that covers all the aspects not only the nad:
- using ovn multi-homing -> https://kubevirt.io/2023/OVN-kubernetes-secondary-networks.html
- using bridge cni -> https://kubevirt.io/2020/Multiple-Network-Attachments-with-bridge-CNI.html
There was a problem hiding this comment.
is there an openshift related doc i can link to that covers this?
There was a problem hiding this comment.
I think this would be the least bad option https://70729--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/multiple_networks/configuring-additional-network
|
|
||
| In this example, the KubeVirt VMs will have interfaces attached to the networks | ||
| for the NetworkAttachmentDefinitions network1 and network2 which reside in | ||
| namespace my-namespace. |
There was a problem hiding this comment.
Don't we need to document also doing it with NodePool CRD ? like creating new nodepools with additional networks.
There was a problem hiding this comment.
IMO that would make sense if we do that for other features. I recall from the openshift documentation we only document CLI based flows.
There was a problem hiding this comment.
we haven't been documenting usage of the APIs directly yet
|
|
||
| In this example, the KubeVirt VMs will have interfaces attached to the networks | ||
| for the NetworkAttachmentDefinitions network1 and network2 which reside in | ||
| namespace my-namespace. |
There was a problem hiding this comment.
IMO that would make sense if we do that for other features. I recall from the openshift documentation we only document CLI based flows.
Signed-off-by: David Vossel <davidvossel@gmail.com>
Signed-off-by: David Vossel <davidvossel@gmail.com>
davidvossel
force-pushed
the
kv-docs-4.15-update
branch
from
df6c99a
to
064f600
Compare
|
/lgtm |
|
@davidvossel: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-hypershift-container-v4.16.0-202402150810.p0.g806005b.assembly.stream.el9 for distgit hypershift. |
This adds KubeVirt platform documentation for the following new features.