New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-27161: reflect NodePool replica count nil in status #3472
OCPBUGS-27161: reflect NodePool replica count nil in status #3472
Conversation
@Patryk-Stefanski: This pull request references Jira Issue OCPBUGS-27161, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Skipping CI for Draft Pull Request. |
/test all |
/test e2e-aws |
1 similar comment
/test e2e-aws |
Triggering the RHTAP test again |
hypershift-operator/controllers/nodepool/nodepool_controller.go
Outdated
Show resolved
Hide resolved
a775c9f
to
8b03698
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryan-cox, Patryk-Stefanski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/retest-required |
/jira refresh |
@Patryk-Stefanski: This pull request references Jira Issue OCPBUGS-27161, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@Patryk-Stefanski: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@Patryk-Stefanski: Jira Issue OCPBUGS-27161: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-27161 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Fix included in accepted release 4.16.0-0.nightly-2024-02-02-224339 |
What this PR does / why we need it: Updates AllMachinesReady and AllNodesHealthy status to false as expected with the message NodePool Replicas set to nil.
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)
format, where issue_number might be a GitHub issue, or a Jira story:Fixes # OCPBUGS-27161
Checklist