Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-36608: Enable InPlace NodePool upgrade test for kubevirt #3517

Merged

Conversation

orenc1
Copy link
Contributor

@orenc1 orenc1 commented Feb 4, 2024

What this PR does / why we need it:
Due to an issue in nmstate in which files on the ostree filesystem have been modified, MCO could not drain the node and apply an RHCOS rollout in place.
This has been fixed in a recent release of RHCOS, thus we can enable it now.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes # https://issues.redhat.com/browse/CNV-36608

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Signed-off-by: Oren Cohen <ocohen@redhat.com>
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 4, 2024

@orenc1: This pull request references CNV-36608 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

What this PR does / why we need it:
Due to an issue in nmstate in which files on the ostree filesystem have been modified, MCO could not drain the node and apply an RHCOS rollout in place.
This has been fixed in a recent release of RHCOS, thus we can enable it now.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes # https://issues.redhat.com/browse/CNV-36608

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 4, 2024
@openshift-ci openshift-ci bot requested review from csrwng and enxebre February 4, 2024 13:33
@openshift-ci openshift-ci bot added area/testing Indicates the PR includes changes for e2e testing and removed do-not-merge/needs-area labels Feb 4, 2024
@orenc1
Copy link
Contributor Author

orenc1 commented Feb 5, 2024

/test e2e-aws

Copy link
Contributor

openshift-ci bot commented Feb 5, 2024

@orenc1: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@orenc1
Copy link
Contributor Author

orenc1 commented Feb 5, 2024

@davidvossel , InPlace Upgrade for kubevirt now works.
from the log:

        --- PASS: TestNodePool/Main/TestNodePoolInPlaceUpgrade (1990.96s)

@qinqon
Copy link
Contributor

qinqon commented Feb 5, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2024
@orenc1 orenc1 changed the title CNV-36608: Enable InPlace upgrade test for kubevirt CNV-36608: Enable InPlace NodePool upgrade test for kubevirt Feb 5, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 5, 2024

@orenc1: This pull request references CNV-36608 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

What this PR does / why we need it:
Due to an issue in nmstate in which files on the ostree filesystem have been modified, MCO could not drain the node and apply an RHCOS rollout in place.
This has been fixed in a recent release of RHCOS, thus we can enable it now.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes # https://issues.redhat.com/browse/CNV-36608

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

@davidvossel davidvossel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Feb 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel, orenc1, qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2024
@orenc1
Copy link
Contributor Author

orenc1 commented Feb 5, 2024

/cherry-pick release-4.15

@openshift-cherrypick-robot

@orenc1: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 3eb5eaf into openshift:main Feb 6, 2024
12 checks passed
@openshift-cherrypick-robot

@orenc1: new pull request created: #3526

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@orenc1 orenc1 deleted the kubevirt_enable_inplace_upgrade branch February 6, 2024 07:21
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-hypershift-container-v4.16.0-202402060810.p0.g3eb5eaf.assembly.stream for distgit hypershift.
All builds following this will include this PR.

orenc1 added a commit to orenc1/hypershift that referenced this pull request Feb 7, 2024
…bevirt

This is a manual cherry-pick of openshift#3517

Signed-off-by: Oren Cohen <ocohen@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Indicates the PR includes changes for e2e testing jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants