Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-JIRA: Remove CLI inspection of release image #3548

Merged
merged 1 commit into from
May 9, 2024
Merged

NO-JIRA: Remove CLI inspection of release image #3548

merged 1 commit into from
May 9, 2024

Conversation

davidvossel
Copy link
Contributor

Previously, the hcp client tool would dynamically inspect the release image to determine what the version was in use, and use that information to default the network type.

That inspection of the release image causes issues in the disconnected use case. It's possible that the machine someone is executing the client on can't directly access the image registry. In this situation, the client fails and prevents a user from being able to create a cluster.

Moving forward, we need the client to only require access to the api server of the mgmt cluster.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 8, 2024
@openshift-ci-robot
Copy link

@davidvossel: This pull request explicitly references no jira issue.

In response to this:

Previously, the hcp client tool would dynamically inspect the release image to determine what the version was in use, and use that information to default the network type.

That inspection of the release image causes issues in the disconnected use case. It's possible that the machine someone is executing the client on can't directly access the image registry. In this situation, the client fails and prevents a user from being able to create a cluster.

Moving forward, we need the client to only require access to the api server of the mgmt cluster.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added area/cli Indicates the PR includes changes for CLI and removed do-not-merge/needs-area labels Feb 8, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2024
@tiraboschi
Copy link
Contributor

Removing func defaultNetworkType cluster creations fails with:

hypershift_framework.go:264: failed to create cluster, tearing down: failed to apply object "e2e-clusters-dhzkh/example-x4kmg": HostedCluster.hypershift.openshift.io "example-x4kmg" is invalid: spec.networking.networkType: Unsupported value: "": supported values: "OpenShiftSDN", "Calico", "OVNKubernetes", "Other"

@tiraboschi
Copy link
Contributor

See #3844

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 5, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 8, 2024
@openshift-ci openshift-ci bot added the area/testing Indicates the PR includes changes for e2e testing label Apr 8, 2024
@tiraboschi tiraboschi mentioned this pull request Apr 15, 2024
Closed
4 tasks
@jparrill
Copy link
Contributor

/retest-required

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 29, 2024
@jparrill
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 6, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2024
@jparrill
Copy link
Contributor

jparrill commented May 6, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2024
@davidvossel
Copy link
Contributor Author

/retest "Red Hat Konflux / hypershift-operator-main-on-pull-request"

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 8, 2024

@davidvossel: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test e2e-aws
  • /test e2e-kubevirt-aws-ovn
  • /test images
  • /test unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test e2e-aws-4-12
  • /test e2e-aws-4-13
  • /test e2e-aws-metrics
  • /test e2e-azure
  • /test e2e-conformance
  • /test e2e-ibmcloud-iks
  • /test e2e-ibmcloud-roks
  • /test e2e-kubevirt-azure-ovn
  • /test e2e-kubevirt-metal-conformance
  • /test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-hypershift-main-e2e-aws
  • pull-ci-openshift-hypershift-main-e2e-azure
  • pull-ci-openshift-hypershift-main-e2e-kubevirt-aws-ovn
  • pull-ci-openshift-hypershift-main-images
  • pull-ci-openshift-hypershift-main-unit
  • pull-ci-openshift-hypershift-main-verify

In response to this:

/retest "Red Hat Konflux / hypershift-operator-main-on-pull-request"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@davidvossel
Copy link
Contributor Author

/test "Red Hat Konflux / hypershift-operator-main-on-pull-request"

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 8, 2024

@davidvossel: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-aws
  • /test e2e-kubevirt-aws-ovn
  • /test images
  • /test unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test e2e-aws-4-12
  • /test e2e-aws-4-13
  • /test e2e-aws-metrics
  • /test e2e-azure
  • /test e2e-conformance
  • /test e2e-ibmcloud-iks
  • /test e2e-ibmcloud-roks
  • /test e2e-kubevirt-azure-ovn
  • /test e2e-kubevirt-metal-conformance
  • /test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-hypershift-main-e2e-aws
  • pull-ci-openshift-hypershift-main-e2e-azure
  • pull-ci-openshift-hypershift-main-e2e-kubevirt-aws-ovn
  • pull-ci-openshift-hypershift-main-images
  • pull-ci-openshift-hypershift-main-unit
  • pull-ci-openshift-hypershift-main-verify

In response to this:

/test "Red Hat Konflux / hypershift-operator-main-on-pull-request"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jparrill
Copy link
Contributor

jparrill commented May 8, 2024

/retest

@davidvossel
Remove CLI inspection of release image
cf27872 
Signed-off-by: David Vossel <davidvossel@gmail.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 8, 2024
@jparrill
Copy link
Contributor

jparrill commented May 8, 2024

/lgtm

1 similar comment
@bryan-cox
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 30fc457 and 2 for PR HEAD cf27872 in total

@davidvossel
Copy link
Contributor Author

/test e2e-aws e2e-azure

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 37b99f5 and 1 for PR HEAD cf27872 in total

@bryan-cox
Copy link
Member

/retest

1 similar comment
@bryan-cox
Copy link
Member

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 905708a and 0 for PR HEAD cf27872 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 9, 2024

@davidvossel: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit a1897c1 into openshift:main May 9, 2024
13 checks passed
@LiangquanLi930
Copy link
Member

/cherry-pick 4.15

@openshift-cherrypick-robot
Copy link

@LiangquanLi930: cannot checkout 4.15: error checking out "4.15": exit status 1 error: pathspec '4.15' did not match any file(s) known to git

In response to this:

/cherry-pick 4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@LiangquanLi930
Copy link
Member

/cherry-pick release-4.15

@LiangquanLi930
Copy link
Member

/cherry-pick release-4.14

@openshift-cherrypick-robot
Copy link

@LiangquanLi930: #3548 failed to apply on top of branch "release-4.15":

Applying: Remove CLI inspection of release image
Using index info to reconstruct a base tree...
M	cmd/cluster/cluster.go
M	cmd/cluster/core/create.go
M	product-cli/cmd/cluster/cluster.go
M	test/e2e/e2e_test.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/e2e_test.go
Auto-merging product-cli/cmd/cluster/cluster.go
Removing cmd/cluster/core/create_test.go
Auto-merging cmd/cluster/core/create.go
CONFLICT (content): Merge conflict in cmd/cluster/core/create.go
Auto-merging cmd/cluster/cluster.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Remove CLI inspection of release image
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

@LiangquanLi930: #3548 failed to apply on top of branch "release-4.14":

Applying: Remove CLI inspection of release image
Using index info to reconstruct a base tree...
M	cmd/cluster/cluster.go
M	cmd/cluster/core/create.go
M	product-cli/cmd/cluster/cluster.go
M	test/e2e/e2e_test.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/e2e_test.go
Auto-merging product-cli/cmd/cluster/cluster.go
Removing cmd/cluster/core/create_test.go
Auto-merging cmd/cluster/core/create.go
CONFLICT (content): Merge conflict in cmd/cluster/core/create.go
Auto-merging cmd/cluster/cluster.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Remove CLI inspection of release image
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@LiangquanLi930 LiangquanLi930 mentioned this pull request May 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enxebre enxebre Awaiting requested review from enxebre

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

Assignees

@jparrill jparrill

@bryan-cox bryan-cox

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cli Indicates the PR includes changes for CLI area/testing Indicates the PR includes changes for e2e testing jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@davidvossel @openshift-ci-robot @tiraboschi @jparrill @bryan-cox @LiangquanLi930 @openshift-cherrypick-robot @openshift-merge-robot