[release-4.15] OCPBUGS-29310: control-plane-pki-operator: validate CN for CSR #3558
Conversation
We were being too permissive for the CN provided in the CSRs we signed. Now, they must have a prefix identifying them as coming from the signer they're using, which makes the requests sent by these credentials auditable. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-29103 has been cloned as Jira Issue OCPBUGS-29310. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-29310, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-bug
|
/approve |
openshift-ci
bot
added
area/control-plane-pki-operator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csrwng, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
approved
|
/lgtm |
|
/test e2e-kubevirt-aws-ovn |
|
/retest |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 0d8195a
into
openshift:release-4.15
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-29310: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-29310 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-hypershift-container-v4.15.0-202402100207.p0.g0d8195a.assembly.stream.el9 for distgit hypershift. |
|
Fix included in accepted release 4.15.0-0.nightly-2024-02-12-213938 |
This is an automated cherry-pick of #3538
/assign stevekuznetsov