Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-29115: Default NodeUpgradeType on day2 nodepool creation #3572

Merged
merged 1 commit into from Feb 15, 2024

Conversation

jparrill
Copy link
Contributor

This bug regards on a day2 nodepool creation. If you creates a cluster using the CLI, it defaults the NodepoolUpgradeType according to the HostedCluster Platform Type. With this PR we also covers the day 2 Nodepool creation which is not using the default fixtures.

Signed-off-by: Juan Manuel Parrilla Madrid jparrill@redhat.com

Which issue(s) this PR fixes :
Fixes #OCPBUGS-29115

Signed-off-by: Juan Manuel Parrilla Madrid <jparrill@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 13, 2024
@openshift-ci-robot
Copy link

@jparrill: This pull request references Jira Issue OCPBUGS-29115, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This bug regards on a day2 nodepool creation. If you creates a cluster using the CLI, it defaults the NodepoolUpgradeType according to the HostedCluster Platform Type. With this PR we also covers the day 2 Nodepool creation which is not using the default fixtures.

Signed-off-by: Juan Manuel Parrilla Madrid jparrill@redhat.com

Which issue(s) this PR fixes :
Fixes #OCPBUGS-29115

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the area/cli Indicates the PR includes changes for CLI label Feb 13, 2024
Copy link
Contributor

openshift-ci bot commented Feb 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Feb 13, 2024
@jparrill
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 13, 2024
@openshift-ci-robot
Copy link

@jparrill: This pull request references Jira Issue OCPBUGS-29115, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (gamado@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@csrwng
Copy link
Contributor

csrwng commented Feb 13, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a58035c and 2 for PR HEAD 194665f in total

@jparrill
Copy link
Contributor Author

/retest

1 similar comment
@jparrill
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b121a20 and 1 for PR HEAD 194665f in total

@bryan-cox
Copy link
Member

/test e2e-kubevirt-aws-ovn

@openshift-merge-bot openshift-merge-bot bot merged commit dccd39a into openshift:main Feb 15, 2024
11 of 12 checks passed
@openshift-ci-robot
Copy link

@jparrill: Jira Issue OCPBUGS-29115: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29115 has been moved to the MODIFIED state.

In response to this:

This bug regards on a day2 nodepool creation. If you creates a cluster using the CLI, it defaults the NodepoolUpgradeType according to the HostedCluster Platform Type. With this PR we also covers the day 2 Nodepool creation which is not using the default fixtures.

Signed-off-by: Juan Manuel Parrilla Madrid jparrill@redhat.com

Which issue(s) this PR fixes :
Fixes #OCPBUGS-29115

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jparrill
Copy link
Contributor Author

/cherry-pick release-4.15

@openshift-cherrypick-robot

@jparrill: new pull request created: #3582

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cli Indicates the PR includes changes for CLI jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants