Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: always set minAvailable on PDBs to 1 #3616

Merged
merged 1 commit into from Feb 21, 2024

Conversation

sjenning
Copy link
Contributor

@sjenning sjenning commented Feb 21, 2024

We are currently experiencing issues in CI when the autoscaler scales down the cluster and evicts pods from actively running mgmt clusters running prow jobs. These mgmt clusters run SingleReplica to save on resources and can not tolerate being evicted without control plane downtime. Depending on when this downtime occurs during the job, it frequently causes flakes.

Setting minAvailable to 1 on deployments that are required for smooth running of the KAS (etcd, kas itself, aggregated apiservers, and ingress to the kas) will prevent these pods from being evicted until the jobs complete.

@openshift-ci openshift-ci bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Feb 21, 2024
@stevekuznetsov
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2024
Copy link
Contributor

openshift-ci bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sjenning, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sjenning sjenning changed the title always set minAvailable on PDBs to 1 NO-JIRA: always set minAvailable on PDBs to 1 Feb 21, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 21, 2024
@openshift-ci-robot
Copy link

@sjenning: This pull request explicitly references no jira issue.

In response to this:

We are currently experiencing issues in CI when the autoscaler scales down the cluster and evicts pods from actively running mgmt clusters running prow jobs. These mgmt clusters run SingleReplica to save on resources and can not tolerate being evicted without control plane downtime. Depending on when this downtime occurs during the job, it frequently causes flakes.

Setting minAvailable to 1 on deployments that are required for smooth running of the KAS (etcd, kas itself, aggregated apiservers, and ingress to the kas) will prevent these pods from being evicted until the jobs complete.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sjenning
Copy link
Contributor Author

/test e2e-aws

Copy link
Contributor

openshift-ci bot commented Feb 21, 2024

@sjenning: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit aa65231 into openshift:main Feb 21, 2024
11 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-hypershift-container-v4.16.0-202402211939.p0.gaa65231.assembly.stream.el9 for distgit hypershift.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants