Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-JIRA: Remove replace statements #3631

Merged
merged 1 commit into from Feb 28, 2024
Merged

NO-JIRA: Remove replace statements #3631

merged 1 commit into from Feb 28, 2024

Conversation

bryan-cox
Copy link
Member

@bryan-cox bryan-cox commented Feb 22, 2024 •
edited

What this PR does / why we need it:
Removed as many replace statements as I could. There are 3 replace statements due to cluster-node-tuning-operator; I put them in their own block for now. Removed these four:

  • k8s.io/cri-api => k8s.io/cri-api v0.28.3
  • kubevirt.io/client-go => kubevirt.io/client-go v0.0.0-00010101000000-000000000000
  • kubevirt.io/containerized-data-importer-api => github.com/kubevirt/containerized-data-importer-api v1.41.1-0.20211201033752-05520fb9f18d
  • sigs.k8s.io/apiserver-network-proxy/konnectivity-client => sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.28.1

Which issue(s) this PR fixes:
N/A

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 22, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 22, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@bryan-cox
Copy link
Member Author

/test images
/test verify
/test unit
/test e2e-aws

@openshift-ci openshift-ci bot added area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI and removed do-not-merge/needs-area labels Feb 22, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2024
@bryan-cox
Copy link
Member Author

/test e2e-kubevirt-aws-ovn

@bryan-cox
Copy link
Member Author

/retitle: NO-JIRA: Remove replace statements

@openshift-ci openshift-ci bot changed the title Remove replace statements : NO-JIRA: Remove replace statements Feb 26, 2024
@openshift-ci-robot
Copy link

@bryan-cox: This pull request explicitly references no jira issue.

In response to this:

What this PR does / why we need it:
Removed as many replace statements as I could. There are 3 replace statements due to cluster-node-tuning-operator; I put them in their own block for now. Removed these four:

  • k8s.io/cri-api => k8s.io/cri-api v0.28.3
  • kubevirt.io/client-go => kubevirt.io/client-go v0.0.0-00010101000000-000000000000
  • kubevirt.io/containerized-data-importer-api => github.com/kubevirt/containerized-data-importer-api v1.41.1-0.20211201033752-05520fb9f18d
  • sigs.k8s.io/apiserver-network-proxy/konnectivity-client => sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.28.1

Which issue(s) this PR fixes:
N/A

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 26, 2024
@Patryk-Stefanski
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2024
@bryan-cox bryan-cox marked this pull request as ready for review February 26, 2024 14:24
@bryan-cox
Copy link
Member Author

/retitle NO-JIRA: Remove replace statements

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 26, 2024
@openshift-ci openshift-ci bot changed the title : NO-JIRA: Remove replace statements NO-JIRA: Remove replace statements Feb 26, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 439f33c and 2 for PR HEAD da0ca1e in total

@bryan-cox
Copy link
Member Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b25eadf and 1 for PR HEAD da0ca1e in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 11d8247 and 0 for PR HEAD da0ca1e in total

@bryan-cox
Copy link
Member Author

/test e2e-aws

@openshift-ci-robot
Copy link

/hold

Revision da0ca1e was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2024
@bryan-cox
Copy link
Member Author

/unhold
/retest-required

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 27, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 27, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2024
@Patryk-Stefanski
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9adaf77 and 2 for PR HEAD 6508398 in total

@bryan-cox
Copy link
Member Author

/retest-required

1 similar comment
@bryan-cox
Copy link
Member Author

/retest-required

@bryan-cox
Copy link
Member Author

/test e2e-aws

@bryan-cox
Copy link
Member Author

/retest-required

1 similar comment
@bryan-cox
Copy link
Member Author

/retest-required

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2024
@bryan-cox
Remove replace statements
04494f8 
Signed-off-by: Bryan Cox <brcox@redhat.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2024
@Patryk-Stefanski
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 28, 2024

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 7c10d2a into openshift:main Feb 28, 2024
12 checks passed
@bryan-cox bryan-cox deleted the update-gomod branch February 28, 2024 18:10
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-hypershift-container-v4.16.0-202402281909.p0.g7c10d2a.assembly.stream.el9 for distgit hypershift.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidvossel davidvossel Awaiting requested review from davidvossel

@enxebre enxebre Awaiting requested review from enxebre

Assignees

@Patryk-Stefanski Patryk-Stefanski

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bryan-cox @openshift-ci-robot @Patryk-Stefanski @openshift-bot @openshift-merge-robot