OCPBUGS-28634: Update agentserviceconfig.md to remove PUBLIC_CONTAINER_REGISTRIES

[CrystalChun]

Instructing customers to override PUBLIC_CONTAINER_REGISTRIES is not ideal since the value specified for that override will completely wipe the default list and they could run into issues getting their images pulled (see https://issues.redhat.com/browse/OCPBUGS-28634). Instead we should provide the option to just add their registry to the default list.

What this PR does / why we need it:
Modifies the document for setting up assisted service to add a customer's registry as a "public" registry (one that doesn't require authentication). Prevents customers from using PUBLIC_CONTAINER_REGISTRIES which will override the default list.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes # https://issues.redhat.com/browse/OCPBUGS-28634

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

/cc @jparrill

[CrystalChun]

/retitle OCPBUGS-28634: Update agentserviceconfig.md to remove PUBLIC_CONTAINER_REGISTRIES

[openshift-ci-robot]

@CrystalChun: This pull request references Jira Issue OCPBUGS-28634, which is invalid:

• expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructing customers to override PUBLIC_CONTAINER_REGISTRIES is not ideal since the value specified for that override will completely wipe the default list and they could run into issues getting their images pulled (see https://issues.redhat.com/browse/OCPBUGS-28634). Instead we should provide the option to just add their registry to the default list.

What this PR does / why we need it:
Modifies the document for setting up assisted service to add a customer's registry as a "public" registry (one that doesn't require authentication). Prevents customers from using PUBLIC_CONTAINER_REGISTRIES which will override the default list.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes # https://issues.redhat.com/browse/OCPBUGS-28634

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

/cc @jparrill

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[netlify]

✅ Deploy Preview for hypershift-docs ready!

Name	Link
🔨 Latest commit	b66364e
🔍 Latest deploy log	https://app.netlify.com/sites/hypershift-docs/deploys/65e737eb366eb8000886defd
😎 Deploy Preview	https://deploy-preview-3687--hypershift-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[CrystalChun]

/jira refresh

[openshift-ci-robot]

@CrystalChun: This pull request references Jira Issue OCPBUGS-28634, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @LiangquanLi930

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[bryan-cox]

/approve

[CrystalChun]

/retest-required

[bryan-cox]

/retest

[jparrill]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, CrystalChun, jparrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [bryan-cox,jparrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@CrystalChun: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@CrystalChun: Jira Issue OCPBUGS-28634: All pull requests linked via external trackers have merged:

• openshift/hypershift#3687

Jira Issue OCPBUGS-28634 has been moved to the MODIFIED state.

In response to this:

Instructing customers to override PUBLIC_CONTAINER_REGISTRIES is not ideal since the value specified for that override will completely wipe the default list and they could run into issues getting their images pulled (see https://issues.redhat.com/browse/OCPBUGS-28634). Instead we should provide the option to just add their registry to the default list.

What this PR does / why we need it:
Modifies the document for setting up assisted service to add a customer's registry as a "public" registry (one that doesn't require authentication). Prevents customers from using PUBLIC_CONTAINER_REGISTRIES which will override the default list.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes # https://issues.redhat.com/browse/OCPBUGS-28634

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

/cc @jparrill

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-hypershift-container-v4.16.0-202403122214.p0.g8f88df1.assembly.stream.el9 for distgit hypershift.
All builds following this will include this PR.