Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOSTEDCP-1465: Create HCPs with externalDNS on AKS Clusters #3688

Merged
merged 8 commits into from Apr 15, 2024
Merged

HOSTEDCP-1465: Create HCPs with externalDNS on AKS Clusters #3688

merged 8 commits into from Apr 15, 2024

Conversation

bryan-cox
Copy link
Member

What this PR does / why we need it:
We need to be able to create HCPs with externalDNS on AKS clusters for ARO HCP.

Which issue(s) this PR fixes:
Fixes HOSTEDCP-1465

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 5, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 5, 2024 •
edited by openshift-ci bot

@bryan-cox: This pull request references HOSTEDCP-1465 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

What this PR does / why we need it:
We need to be able to create HCPs with externalDNS on AKS clusters for ARO HCP.

Which issue(s) this PR fixes:
Fixes HOSTEDCP-1465

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 5, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 5, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@bryan-cox bryan-cox changed the title HOSTEDCP-1465: Create HCPs with external DNS on AKS Clusters HOSTEDCP-1465: Create HCPs with externalDNS on AKS Clusters Mar 5, 2024
@openshift-ci openshift-ci bot added the area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release label Mar 5, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Mar 5, 2024
@openshift-ci openshift-ci bot added the area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release label Mar 9, 2024
@openshift-ci openshift-ci bot added the area/cli Indicates the PR includes changes for CLI label Mar 12, 2024
@bryan-cox bryan-cox force-pushed the HOSTEDCP-1465 branch 6 times, most recently from 0a53780 to 741d413 Compare March 12, 2024 19:07
@netlify Netlify
Copy link

netlify bot commented Mar 12, 2024

✅ Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit 0a53780
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/65f0a79fb07ad30008f6a36b
😎 Deploy Preview https://deploy-preview-3688--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bryan-cox bryan-cox force-pushed the HOSTEDCP-1465 branch 2 times, most recently from 701ffe7 to e418e8f Compare March 12, 2024 19:59
@openshift-ci openshift-ci bot added the area/documentation Indicates the PR includes changes for documentation label Mar 12, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 12, 2024 •
edited

✅ Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit 3b37b3d
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/6617d754d7bb4100086db3dc
😎 Deploy Preview https://deploy-preview-3688--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bryan-cox bryan-cox force-pushed the HOSTEDCP-1465 branch 2 times, most recently from 584457f to dccc54f Compare March 12, 2024 20:54
@bryan-cox bryan-cox mentioned this pull request Mar 14, 2024
Merged
@bryan-cox bryan-cox force-pushed the HOSTEDCP-1465 branch 2 times, most recently from cf8595a to d2db64e Compare March 15, 2024 16:40
@bryan-cox
Copy link
Member Author

/test e2e-aws

@bryan-cox
Copy link
Member Author

/retest

@bryan-cox
Copy link
Member Author

/test e2e-aws

1 similar comment
@bryan-cox
Copy link
Member Author

/test e2e-aws

@sjenning
Copy link
Contributor

/override ci/prow/e2e-aws

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 12, 2024

@sjenning: Overrode contexts on behalf of sjenning: ci/prow/e2e-aws

In response to this:

/override ci/prow/e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bryan-cox
Copy link
Member Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2024
@sjenning
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 141ab9c and 2 for PR HEAD 3b37b3d in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e446c10 and 1 for PR HEAD 3b37b3d in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 0142eed and 0 for PR HEAD 3b37b3d in total

@bryan-cox
Copy link
Member Author

bryan-cox commented Apr 15, 2024 •
edited

Seth's override didn't seem to take effect.

@bryan-cox
Copy link
Member Author

/override ci/prow/e2e-aws

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 15, 2024

@bryan-cox: Overrode contexts on behalf of bryan-cox: ci/prow/e2e-aws

In response to this:

Seth's override didn't seem to take effect.
/override ci/prow/e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 15, 2024

@bryan-cox: Overrode contexts on behalf of bryan-cox: ci/prow/e2e-aws

In response to this:

/override ci/prow/e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

/hold

Revision 3b37b3d was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2024
@bryan-cox
Copy link
Member Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a0a2fca and 2 for PR HEAD 3b37b3d in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 15, 2024 •
edited

@bryan-cox: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-kubevirt-azure-ovn 24a4504 link false /test e2e-kubevirt-azure-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bryan-cox
Copy link
Member Author

I guess the PR going into hold reverses the override.
/override ci/prow/e2e-aws

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 15, 2024

@bryan-cox: Overrode contexts on behalf of bryan-cox: ci/prow/e2e-aws

In response to this:

I guess the PR going into hold reverses the override.
/override ci/prow/e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 0ffbfef into openshift:main Apr 15, 2024
12 checks passed
@bryan-cox bryan-cox deleted the HOSTEDCP-1465 branch April 15, 2024 16:40
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-hypershift-container-v4.16.0-202404151450.p0.g0ffbfef.assembly.stream.el9 for distgit hypershift.
All builds following this will include this PR.

@bryan-cox bryan-cox restored the HOSTEDCP-1465 branch April 16, 2024 11:27
@bryan-cox bryan-cox mentioned this pull request Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukrishn mukrishn mukrishn left review comments

@Patryk-Stefanski Patryk-Stefanski Patryk-Stefanski left review comments

@csrwng csrwng Awaiting requested review from csrwng

@enxebre enxebre Awaiting requested review from enxebre

Assignees

@sjenning sjenning

@csrwng csrwng

@Patryk-Stefanski Patryk-Stefanski

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cli Indicates the PR includes changes for CLI area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/control-plane-pki-operator Indicates the PR includes changes for the control plane PKI operator - in an OCP release area/documentation Indicates the PR includes changes for documentation area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@bryan-cox @openshift-ci-robot @Patryk-Stefanski @csrwng @sjenning @openshift-bot @mukrishn @openshift-merge-robot